Check zone id before jdbc access #2616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup sonar issues
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/186543591 The labels on this github issue will be updated when the story is started. |
strehle
commented
Nov 23, 2023
server/src/main/java/org/cloudfoundry/identity/uaa/scim/jdbc/JdbcScimGroupProvisioning.java
Show resolved
Hide resolved
strehle
changed the title
|
@swalchemist similar to zone check here a small PR which does a group id check before JDBC call. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussions in #2606
Add null checks to improve robustness in this dao using validateZoneId helper.
Cleanup sonar issues, found by IDE plugin
https://sonarcloud.io/summary/new_code?id=cloudfoundry-identity-parent&pullRequest=2616