fix flaky test #2565
Merged
fix flaky test #2565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class and many nested test classes The result is, that jku_test is deleted and recreated in parallel and this leads to inconsistency which can be solved with the retry. We have this retry on other places already. Therefore add it now here again. In real such issues wont happen therefore we maybe should solve this with creating own clients for all nested tests Most failing test seen validExpClaim
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/186307126 The labels on this github issue will be updated when the story is started. |
peterhaochen47
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class has many nested test classes
The result is, that oauth client jku_test is deleted and recreated in parallel and this leads to inconsistency which can be solved with the retry. We have this retry on other places already.
Therefore add it now here again. In real such issues wont happen therefore we maybe should solve this with creating own clients for all nested tests. It obviously occurs now more often, why I can not say, but this will prevent it.
Most failing test seen validExpClaim