fix: unnecessary method call (#2549)

* fix sonar issue: Utility classes should not have public constructors * fix: possibly unnecessary method call * fix: define Java version * handle in separate PR
cloudfoundry · Oct 23, 2023 · 1bb8a2b · 1bb8a2b
1 parent fe95b5c
commit 1bb8a2b
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/...src/main/java/org/cloudfoundry/identity/uaa/scim/jdbc/JdbcScimGroupMembershipManager.java b/...src/main/java/org/cloudfoundry/identity/uaa/scim/jdbc/JdbcScimGroupMembershipManager.java
@@ -118,10 +118,9 @@ private Set<ScimGroup> getDefaultUserGroups(String zoneId) {
             return emptySet();
         }
         IdentityZone currentZone = IdentityZoneHolder.get();
-        List<String> zoneDefaultGroups = currentZone.getConfig().getUserConfig().getDefaultGroups();
-        if (!zoneId.equals(currentZone.getId())) {
-            zoneDefaultGroups = zoneProvisioning.retrieve(zoneId).getConfig().getUserConfig().getDefaultGroups();
-        }
+        List<String> zoneDefaultGroups = (zoneId.equals(currentZone.getId())) ?
+                currentZone.getConfig().getUserConfig().getDefaultGroups() :
+                zoneProvisioning.retrieve(zoneId).getConfig().getUserConfig().getDefaultGroups();
         return zoneDefaultGroups
                 .stream()
                 .map(groupName -> createOrGetGroup(groupName, zoneId))