Support managed binding parameters #3698
Merged
+518
−182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introduce the optional `CFServiceBinding.Spec.Parameters` to reference a secret to store the binding parameters * The parameters secret is created by the binding repository. `kubectl` users should create it themselves if they want to provide such parameters * The binding parameters are sent to the broker on `bind`. If `Spec.Parameters` is not set, no parameters are sent to the broker issue #3549 Co-authored-by: Danail Branekov <[email protected]> Co-authored-by: Georgi Sabev <[email protected]>
georgethebeatle
force-pushed
the
issues/3549-cf-bind-with-parameters
branch
from
c3ce57e to
4ffdd57
Compare
georgethebeatle
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#3549
What is this change about?
CFServiceBinding.Spec.Parametersto reference a secret tostore the binding parameters
kubectlusers should create it themselves if they want to provide such
parameters
bind. IfSpec.Parametersis not set, no parameters are sent to the brokerTag your pair, your PM, and/or team
@georgethebeatle