Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RFC 0027: Unify load balancing property name #1039

Merged

Conversation

a18e
Copy link
Contributor

@a18e a18e commented Dec 18, 2024

In cloudfoundry/capi-release#482, it was decided to unify the API property and internal state for the per-route load-balancing algorithm feature to loadbalancing. This was already introduced into cloud controller in cloudfoundry/cloud_controller_ng#4080

The following component PRs accompany this change in the RFC:

Unify loadbalancing property
@a18e a18e marked this pull request as ready for review December 18, 2024 15:07
@maxmoehl
Copy link
Member

@beyhan this is ready to be reviewed. Do we need full TOC approval for such updates?

@maxmoehl maxmoehl mentioned this pull request Dec 18, 2024
@beyhan beyhan requested review from a team, rkoster, beyhan, stephanme, ameowlia and ChrisMcGowan and removed request for a team December 19, 2024 10:05
@beyhan beyhan added toc rfc CFF community RFC labels Dec 19, 2024
@beyhan
Copy link
Member

beyhan commented Dec 19, 2024

@maxmoehl yes, we need.

@rkoster
Copy link
Contributor

rkoster commented Jan 7, 2025

Change was proposed here: cloudfoundry/capi-release#482 (comment)

Copy link
Member

@ameowlia ameowlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to route registrar will alter bosh properties that already exist. This will need to be marked as a breaking change. I'll comment more on specific PRs.

@beyhan beyhan merged commit 671be28 into cloudfoundry:main Jan 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfc CFF community RFC toc
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants