h3i: Improve ConnectionSummary stream_map serialization #1927
+24
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ConnectionSummary can be serialized to help other tooling consume the output of h3i. Previously we didn't support the seralization of DATA frame payloads. Furthermore, we were a bit inconsistent with how we serialize frames with binary payloads. This change adds support for logging DATA frame payloads and ensures that all frames consistently have a `_len` field to indicate the true length of the frame. Documentation has been added with a pointer to the hexstring qlog definition that we use here. Closes #1917
ghedo
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ConnectionSummary can be serialized to help other tooling consume
the output of h3i. Previously we didn't support the seralization of
DATA frame payloads. Furthermore, we were a bit inconsistent with how
we serialize frames with binary payloads.
This change adds support for logging DATA frame payloads and ensures
that all frames consistently have a
_lenfield to indicate the truelength of the frame. Documentation has been added with a pointer to
the hexstring qlog definition that we use here.
Closes #1917