Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically disable unsupported checks #1249

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Automatically disable unsupported checks #1249

merged 2 commits into from
Jan 7, 2025

Conversation

prymitive
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.69.1-50-g23e7dcc
Number of rules parsed 4
Number of rules checked 4
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

Copy link

github-actions bot commented Jan 6, 2025

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   40.36m ± 2%   40.48m ± 6%       ~ (p=0.481 n=10)
CheckRules-4     8.526 ± 2%    8.542 ± 2%       ~ (p=0.315 n=10)
geomean         586.6m        588.0m       +0.24%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   27.40Mi ± 0%   27.40Mi ± 0%       ~ (p=0.143 n=10)
CheckRules-4    975.8Mi ± 0%   973.3Mi ± 0%  -0.26% (p=0.004 n=10)
geomean         163.5Mi        163.3Mi       -0.13%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   131.7k ± 0%   131.7k ± 0%       ~ (p=0.441 n=10)
CheckRules-4    14.14M ± 0%   14.13M ± 0%  -0.09% (p=0.000 n=10)
geomean         1.365M        1.364M       -0.05%

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 96.31336% with 8 lines in your changes missing coverage. Please review.

Project coverage is 95.20%. Comparing base (a854f3a) to head (23e7dcc).

Files with missing lines Patch % Lines
internal/reporter/gitlab.go 70.37% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1249      +/-   ##
==========================================
+ Coverage   95.12%   95.20%   +0.07%     
==========================================
  Files         105      105              
  Lines       12627    12792     +165     
==========================================
+ Hits        12012    12179     +167     
+ Misses        467      466       -1     
+ Partials      148      147       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive force-pushed the apis branch 4 times, most recently from ed7acd4 to 78dd292 Compare January 7, 2025 11:22
@prymitive prymitive merged commit f0abcd7 into main Jan 7, 2025
20 checks passed
@prymitive prymitive deleted the apis branch January 7, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants