Merge pull request #648 from cloudflare/issue-645

Ensure we always use modified lines
cloudflare · Jun 9, 2023 · badbfd0 · badbfd0
2 parents 287e264 + 576e5ca
commit badbfd0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/docs/changelog.md b/docs/changelog.md
@@ -6,6 +6,7 @@
 
 - Rule names were not checked for correctly, allowing for rules with empty names
   to pass checks.
+- Fixed GitHub annotations being added to unmodified lines - #645.
 
 ## v0.44.0
 

diff --git a/internal/reporter/bitbucket.go b/internal/reporter/bitbucket.go
@@ -270,11 +270,8 @@ func moveReportedLine(report Report) (reported, original int) {
 		}
 	}
 
-	if reported < 0 && report.Problem.Severity == checks.Fatal {
-		for _, ml := range report.ModifiedLines {
-			reported = ml
-			break
-		}
+	if reported < 0 && len(report.ModifiedLines) > 0 {
+		return report.ModifiedLines[0], original
 	}
 
 	return reported, original