Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mangen): Separate options based on help_heading #5854

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

0xAdk
Copy link
Contributor

@0xAdk 0xAdk commented Dec 22, 2024

An implementation for #3363

Could also make this a flag on Man.

@0xAdk
Copy link
Contributor Author

0xAdk commented Dec 22, 2024

The extra headers are added after the "OPTIONS" heading as their own headings, I could've also used .SS like ripgrep does for it's option categories
image
though imo it looked a little odd

@epage
Copy link
Member

epage commented Dec 24, 2024

Thanks for putting this together! I don't use man pages enough to say whether to do your approach or ripgreps but we can just go for one now and see what feedback we get.

@0xAdk 0xAdk force-pushed the feat/mangen_respect_help_heading branch from f010f38 to ba776e9 Compare December 24, 2024 11:41
@0xAdk 0xAdk force-pushed the feat/mangen_respect_help_heading branch from ba776e9 to 6f6a376 Compare December 24, 2024 11:59
@0xAdk
Copy link
Contributor Author

0xAdk commented Jan 10, 2025

hey just wanted to follow up, is there anything blocking this?

@epage
Copy link
Member

epage commented Jan 10, 2025

hey just wanted to follow up, is there anything blocking this?

This was posted during the holidays and I am still catching up with everything

@epage epage merged commit 760d81a into clap-rs:master Jan 10, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants