-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move citation-number
test that depend on off-spec behavior to off-spec
folder
#64
Conversation
These test were modified in the past so they no longer match their names
For some odd reason (given the fairly infrequent merges here), you have merge conflicts! Aside from fixing those, RTM? |
@bdarcus are you still seeing conflicts? In the GitHub interface, I’m seeing |
Ah, one thing I just noticed … In the future, I need to PR from branches on my fork. I made my test-suite fork a submodule of my Swift processor project so whatever I see to adjust there is immediately incorporated into any open PR here — not quite what I intended. It also makes the commit description weird since I’m generally describing processor changes, not the test tweaks. |
@bdarcus Maybe I’ll try to clean this up by closing this PR, making a branch on my fork, as just described, and PR’ing from there 🤷♂️ |
Made new PR from branch #65 |
Per conversation in #53 (comment)
Tests that show a reversed
citation-number
depend on overloaded behavior not defined in the specification. I left in placecitation-number
tests that show an ascendingcitation-number
. I think those are basically no-ops anyway.I considered updating
processor.py
with an argument to optionally include this folder but I’m not sure how often it’s used. It didn’t look like it was updated for theprocessor-tests/humans/experiments
folder so maybe not needed.