Add ignore.txt list to test suite #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until #17 is addressed, this borrows the ignore.txt list from the citeproc-rs project, with explanation, to provide guidance to implementers on which tests they should ignore.
These two tests rely on undocumented modes from citeproc.js. Closes #16.
bdarcus
commented
May 27, 2020
| bibheader_SecondFieldAlignWithNumber.txt | ||
|
|
||
| # citation-rtf mode | ||
| bugreports_NonBreakingSpaceJoinFail.txt |
There was a problem hiding this comment.
@fbennett can we indeed add these last two items to the ignore list, based on their reliance on undocumented (in CSL) modes?
bdarcus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until #17 is addressed, this borrows the ignore.txt list from the
citeproc-rs project, with explanation, to provide guidance to
implementers on which tests they should ignore.
The format of this file is designed for easy machine processing;
just a single filename per line.
Items are on this list because they rely on undocumented modes
specific to one implementation.