Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the accademia-alfonsiana.csl style to the repository #7338

Open
wants to merge 4 commits into
base: v1.0.2
Choose a base branch
from

Conversation

derreckcssr
Copy link

This is a style that is being used for the Alphonsian Academy in Rome. Making it available in the repository will be helpful for the students to directly access the style.
Our academy website is: https://www.alfonsiana.org

This is a style that is being used for the Alphonsian Academy in Rome. Making it available in the repository will be helpful for the students to directly access the style.
Our academy website is: https://www.alfonsiana.org
Copy link

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

Copy link

😟 There are some issues with your submission.

7 tests failed

The CSL Style Repository may not contain any duplicate file names

expected: []
     got: ["survey-of-ophthalmology"]

(compared using ==)

The CSL Style Repository may not contain any (non-excepted) duplicate ISSNs

expected: {}
     got: {"0036-7834"=>["revue-suisse-dhistoire", "rivista-storica-svizzera", "schweizerische-zeitschrift-fur-...-academy-of-sciences-numeric"], "1879-3304"=>["survey-of-ophthalmology", "survey-of-ophthalmology"]}

(compared using ==)

Diff:
@@ -1,6 +1,12 @@
+"0036-7834" => ["revue-suisse-dhistoire", "rivista-storica-svizzera", "schweizerische-zeitschrift-fur-geschichte"],
+"0037-2781" => ["rassegna-degli-archivi-di-stato-bibliografia-generale", "rassegna-degli-archivi-di-stato"],
+"0039-6257" => ["survey-of-ophthalmology", "survey-of-ophthalmology"],
+"1736-6046" => ["proceedings-of-the-estonian-academy-of-sciences-author-date", "proceedings-of-the-estonian-academy-of-sciences-numeric"],
+"1736-7530" => ["proceedings-of-the-estonian-academy-of-sciences-author-date", "proceedings-of-the-estonian-academy-of-sciences-numeric"],
+"1879-3304" => ["survey-of-ophthalmology", "survey-of-ophthalmology"],

The CSL Style Repository may not contain any duplicate style titles

expected: {}
     got: {"survey of ophthalmology"=>["survey-of-ophthalmology", "survey-of-ophthalmology"]}

(compared using ==)

Diff:
@@ -1 +1,2 @@
+"survey of ophthalmology" => ["survey-of-ophthalmology", "survey-of-ophthalmology"],

The CSL Style Repository may not contain extra files (make sure styles have a ".csl" extension)

expected: []
     got: ["/home/runner/work/styles/styles/pull-request/composer.json"]

(compared using ==)

The file "renamed-styles.json" may not redirect to styles not present in the repository

expected: []
     got: ["harvard-oxford-brookes-university-faculty-of-health-and-life-sciences"]

(compared using ==)

accademia-alfonsiana: name nodes must have valid et-al-min and et-al-use-first attributes

expected et-al-min (6) to be greater than et-al-use-first (6)

chicago-author-date-no-em-dash: may not have any unused macros

expected: []
     got: ["editor", "translator"]

(compared using ==)

Please check the test report for details.

I noticed an error with the title. Removing the title-id, to verify if it is the source of the error
Copy link

😟 There are some issues with your submission.

7 tests failed

The CSL Style Repository may not contain any duplicate file names

expected: []
     got: ["survey-of-ophthalmology"]

(compared using ==)

The CSL Style Repository may not contain any (non-excepted) duplicate ISSNs

expected: {}
     got: {"0036-7834"=>["revue-suisse-dhistoire", "rivista-storica-svizzera", "schweizerische-zeitschrift-fur-...-academy-of-sciences-numeric"], "1879-3304"=>["survey-of-ophthalmology", "survey-of-ophthalmology"]}

(compared using ==)

Diff:
@@ -1,6 +1,12 @@
+"0036-7834" => ["revue-suisse-dhistoire", "rivista-storica-svizzera", "schweizerische-zeitschrift-fur-geschichte"],
+"0037-2781" => ["rassegna-degli-archivi-di-stato-bibliografia-generale", "rassegna-degli-archivi-di-stato"],
+"0039-6257" => ["survey-of-ophthalmology", "survey-of-ophthalmology"],
+"1736-6046" => ["proceedings-of-the-estonian-academy-of-sciences-author-date", "proceedings-of-the-estonian-academy-of-sciences-numeric"],
+"1736-7530" => ["proceedings-of-the-estonian-academy-of-sciences-author-date", "proceedings-of-the-estonian-academy-of-sciences-numeric"],
+"1879-3304" => ["survey-of-ophthalmology", "survey-of-ophthalmology"],

The CSL Style Repository may not contain any duplicate style titles

expected: {}
     got: {"survey of ophthalmology"=>["survey-of-ophthalmology", "survey-of-ophthalmology"]}

(compared using ==)

Diff:
@@ -1 +1,2 @@
+"survey of ophthalmology" => ["survey-of-ophthalmology", "survey-of-ophthalmology"],

The CSL Style Repository may not contain extra files (make sure styles have a ".csl" extension)

expected: []
     got: ["/home/runner/work/styles/styles/pull-request/composer.json"]

(compared using ==)

The file "renamed-styles.json" may not redirect to styles not present in the repository

expected: []
     got: ["harvard-oxford-brookes-university-faculty-of-health-and-life-sciences"]

(compared using ==)

accademia-alfonsiana: name nodes must have valid et-al-min and et-al-use-first attributes

expected et-al-min (6) to be greater than et-al-use-first (6)

chicago-author-date-no-em-dash: may not have any unused macros

expected: []
     got: ["editor", "translator"]

(compared using ==)

Please check the test report for details.

Trying to fix the errors
Copy link

😟 There are some issues with your submission.

7 tests failed

The CSL Style Repository may not contain any duplicate file names

expected: []
     got: ["survey-of-ophthalmology"]

(compared using ==)

The CSL Style Repository may not contain any (non-excepted) duplicate ISSNs

expected: {}
     got: {"0036-7834"=>["revue-suisse-dhistoire", "rivista-storica-svizzera", "schweizerische-zeitschrift-fur-...-academy-of-sciences-numeric"], "1879-3304"=>["survey-of-ophthalmology", "survey-of-ophthalmology"]}

(compared using ==)

Diff:
@@ -1,6 +1,12 @@
+"0036-7834" => ["revue-suisse-dhistoire", "rivista-storica-svizzera", "schweizerische-zeitschrift-fur-geschichte"],
+"0037-2781" => ["rassegna-degli-archivi-di-stato-bibliografia-generale", "rassegna-degli-archivi-di-stato"],
+"0039-6257" => ["survey-of-ophthalmology", "survey-of-ophthalmology"],
+"1736-6046" => ["proceedings-of-the-estonian-academy-of-sciences-author-date", "proceedings-of-the-estonian-academy-of-sciences-numeric"],
+"1736-7530" => ["proceedings-of-the-estonian-academy-of-sciences-author-date", "proceedings-of-the-estonian-academy-of-sciences-numeric"],
+"1879-3304" => ["survey-of-ophthalmology", "survey-of-ophthalmology"],

The CSL Style Repository may not contain any duplicate style titles

expected: {}
     got: {"survey of ophthalmology"=>["survey-of-ophthalmology", "survey-of-ophthalmology"]}

(compared using ==)

Diff:
@@ -1 +1,2 @@
+"survey of ophthalmology" => ["survey-of-ophthalmology", "survey-of-ophthalmology"],

The CSL Style Repository may not contain extra files (make sure styles have a ".csl" extension)

expected: []
     got: ["/home/runner/work/styles/styles/pull-request/composer.json"]

(compared using ==)

The file "renamed-styles.json" may not redirect to styles not present in the repository

expected: []
     got: ["harvard-oxford-brookes-university-faculty-of-health-and-life-sciences"]

(compared using ==)

accademia-alfonsiana: name nodes must have valid et-al-min and et-al-use-first attributes

expected et-al-min (1) to be greater than et-al-use-first (4)

chicago-author-date-no-em-dash: may not have any unused macros

expected: []
     got: ["editor", "translator"]

(compared using ==)

Please check the test report for details.

Trying to fix the errors
Copy link

😟 There are some issues with your submission.

6 tests failed

The CSL Style Repository may not contain any duplicate file names

expected: []
     got: ["survey-of-ophthalmology"]

(compared using ==)

The CSL Style Repository may not contain any (non-excepted) duplicate ISSNs

expected: {}
     got: {"0036-7834"=>["revue-suisse-dhistoire", "rivista-storica-svizzera", "schweizerische-zeitschrift-fur-...-academy-of-sciences-numeric"], "1879-3304"=>["survey-of-ophthalmology", "survey-of-ophthalmology"]}

(compared using ==)

Diff:
@@ -1,6 +1,12 @@
+"0036-7834" => ["revue-suisse-dhistoire", "rivista-storica-svizzera", "schweizerische-zeitschrift-fur-geschichte"],
+"0037-2781" => ["rassegna-degli-archivi-di-stato-bibliografia-generale", "rassegna-degli-archivi-di-stato"],
+"0039-6257" => ["survey-of-ophthalmology", "survey-of-ophthalmology"],
+"1736-6046" => ["proceedings-of-the-estonian-academy-of-sciences-author-date", "proceedings-of-the-estonian-academy-of-sciences-numeric"],
+"1736-7530" => ["proceedings-of-the-estonian-academy-of-sciences-author-date", "proceedings-of-the-estonian-academy-of-sciences-numeric"],
+"1879-3304" => ["survey-of-ophthalmology", "survey-of-ophthalmology"],

The CSL Style Repository may not contain any duplicate style titles

expected: {}
     got: {"survey of ophthalmology"=>["survey-of-ophthalmology", "survey-of-ophthalmology"]}

(compared using ==)

Diff:
@@ -1 +1,2 @@
+"survey of ophthalmology" => ["survey-of-ophthalmology", "survey-of-ophthalmology"],

The CSL Style Repository may not contain extra files (make sure styles have a ".csl" extension)

expected: []
     got: ["/home/runner/work/styles/styles/pull-request/composer.json"]

(compared using ==)

The file "renamed-styles.json" may not redirect to styles not present in the repository

expected: []
     got: ["harvard-oxford-brookes-university-faculty-of-health-and-life-sciences"]

(compared using ==)

chicago-author-date-no-em-dash: may not have any unused macros

expected: []
     got: ["editor", "translator"]

(compared using ==)

Please check the test report for details.

@derreckcssr
Copy link
Author

Hi, I would like to request your help in identifying the errors. Thank you.

@adam3smith
Copy link
Member

Ignore the errors; there's a problem in the automated checks cc @retorquere the safe_load doesn't appear to work correctly?

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Nov 25, 2024
@retorquere
Copy link
Collaborator

I'll take a look when I'm home

@derreckcssr
Copy link
Author

Thank you for the response. How do I proceed with submission of the csl for the repository?

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Nov 26, 2024
@retorquere
Copy link
Collaborator

I have reverted the safe_load for now, but to fix the problem in this PR, it will have to merge master

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants