Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Bern-University-of-Applied-Sciences_Institute-for-Digital-Econ… #6772

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

BFH-wht2
Copy link

@BFH-wht2 BFH-wht2 commented Nov 9, 2023

…omy-in-the-Construction-and-Wood-Industry_IdBH.csl

First version for sharing the harmonized citation style of this institute (IdBH).

…omy-in-the-Construction-and-Wood-Industry_IdBH.csl

First version for sharing the harmonized citation style of this institute (IdBH).
Copy link

github-actions bot commented Nov 9, 2023

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

Copy link

github-actions bot commented Nov 9, 2023

😟 There are some issues with your submission.

2 tests failed

Bern-University-of-Applied-Sciences_Institute-for-Digital-Economy-in-the-Construction-and-Wood-Industry_IdBH: must have a conventional file name

expected "Bern-University-of-Applied-Sciences_Institute-for-Digital-Economy-in-the-Construction-and-Wood-Industry_IdBH.csl" to match /^[a-z\d]+(-[a-z\d]+)*\.csl$/
Diff:
@@ -1 +1 @@
-/^[a-z\d]+(-[a-z\d]+)*\.csl$/
+"Bern-University-of-Applied-Sciences_Institute-for-Digital-Economy-in-the-Construction-and-Wood-Industry_IdBH.csl"

Bern-University-of-Applied-Sciences_Institute-for-Digital-Economy-in-the-Construction-and-Wood-Industry_IdBH: style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa")

expected: "http://www.zotero.org/styles/Bern-University-of-Applied-Sciences_Institute-for-Digital-Economy-in-the-Construction-and-Wood-Industry_IdBH"
     got: "http://www.zotero.org/styles/elsevier-harvard"

(compared using ==)

Please check the test report for details.

…omy-in-the-Construction-and-Wood-Industry_IdBH.csl

Corrections in the area of the "ID" and the "link", corresponding adaptation to the style.
Copy link

github-actions bot commented Nov 9, 2023

😟 There are some issues with your submission.

2 tests failed

Bern-University-of-Applied-Sciences_Institute-for-Digital-Economy-in-the-Construction-and-Wood-Industry_IdBH: must have a conventional file name

expected "Bern-University-of-Applied-Sciences_Institute-for-Digital-Economy-in-the-Construction-and-Wood-Industry_IdBH.csl" to match /^[a-z\d]+(-[a-z\d]+)*\.csl$/
Diff:
@@ -1 +1 @@
-/^[a-z\d]+(-[a-z\d]+)*\.csl$/
+"Bern-University-of-Applied-Sciences_Institute-for-Digital-Economy-in-the-Construction-and-Wood-Industry_IdBH.csl"

Bern-University-of-Applied-Sciences_Institute-for-Digital-Economy-in-the-Construction-and-Wood-Industry_IdBH: style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa")

expected: "http://www.zotero.org/styles/Bern-University-of-Applied-Sciences_Institute-for-Digital-Economy-in-the-Construction-and-Wood-Industry_IdBH"
     got: "http://www.zotero.org/styles/bern-university-of-applied-sciences-institute-for-digital-economy-in-the-construction-and-wood-industry-idbh"

(compared using ==)

Please check the test report for details.

…omy-in-the-Construction-and-Wood-Industry_IdBH.csl to bern-university-of-applied-sciences-institute-for-digital-economy-in-the-construction-and-wood-industry-idbh.csl

Corrections in the file name.
Copy link

github-actions bot commented Nov 9, 2023

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

bern-university-of-applied-sciences-institute-for-digital-economy-in-the-construction-and-wood-industry-idbh.csl (new)
(“CSL search by example,” 2012; Hancké et al., 2007)
(Fenner et al., 2019; Mares, 2001)

CSL search by example [online publication], 2012. [online publication]. Citation Style Editor. http://editor.citationstyles.org/searchByExample/ (accessed on 12.15.2012).
Fenner, M., Crosas, M., Grethe, J.S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., Clark, T., 2019. A data citation roadmap for scholarly data repositories. Sci. Data 6, 28. https://doi.org/10.1038/s41597-019-0031-8.
Hancké, B., Rhodes, M., Thatcher, M. (Eds.), 2007. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press, Oxford and New York.
Mares, I., 2001. Firms and the welfare state: When, why, and how does social policy matter to employers?, Oxford University Press, in: Hall, P.A., Soskice, D. (Eds.), Varieties of Capitalism. The Institutional Foundations of Comparative Advantage. Oxford University Press, New York, pp. 184–213.

…omy-in-the-construction-and-wood-industry-idbh.csl

Add the issue and pages to the articles.
Copy link

github-actions bot commented Nov 9, 2023

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

bern-university-of-applied-sciences-institute-for-digital-economy-in-the-construction-and-wood-industry-idbh.csl (new)
(“CSL search by example,” 2012; Hancké et al., 2007)
(Fenner et al., 2019; Mares, 2001)

CSL search by example [online publication], 2012. [online publication]. Citation Style Editor. http://editor.citationstyles.org/searchByExample/ (accessed on 12.15.2012).
Fenner, M., Crosas, M., Grethe, J.S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., Clark, T., 2019. A data citation roadmap for scholarly data repositories. Sci. Data 6 - edition 1, pages 28. https://doi.org/10.1038/s41597-019-0031-8.
Hancké, B., Rhodes, M., Thatcher, M. (Eds.), 2007. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press, Oxford and New York.
Mares, I., 2001. Firms and the welfare state: When, why, and how does social policy matter to employers?, Oxford University Press, in: Hall, P.A., Soskice, D. (Eds.), Varieties of Capitalism. The Institutional Foundations of Comparative Advantage. Oxford University Press, New York, pp. pages 184–213.

BFH-wht2 and others added 2 commits November 9, 2023 10:55
…omy-in-the-construction-and-wood-industry-idbh.csl

Update of content in the area of conferences and paper-conference.
Copy link

github-actions bot commented Nov 9, 2023

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

bern-university-of-applied-sciences-institute-for-digital-economy-in-the-construction-and-wood-industry-idbh.csl (new)
(“CSL search by example,” 2012; Hancké et al., 2007)
(Fenner et al., 2019; Mares, 2001)

CSL search by example [online publication], 2012. [online publication]. Citation Style Editor. http://editor.citationstyles.org/searchByExample/ (accessed on 15.12.2012).
Fenner, M., Crosas, M., Grethe, J.S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., Clark, T., 2019. A data citation roadmap for scholarly data repositories. Sci. Data 6 - edition 1, pages 28. https://doi.org/10.1038/s41597-019-0031-8.
Hancké, B., Rhodes, M., Thatcher, M. (Eds.), 2007. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press, Oxford and New York.
Mares, I., 2001. Firms and the welfare state: When, why, and how does social policy matter to employers?, Oxford University Press, in: Hall, P.A., Soskice, D. (Eds.), Varieties of Capitalism. The Institutional Foundations of Comparative Advantage. Oxford University Press, New York, pp. pages 184–213.

@adam3smith
Copy link
Member

Do you have a link to or a copy of the author guidelines/style manual for this?

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Nov 21, 2023
@BFH-wht2
Copy link
Author

We have an internal document on how to record the various sources. This is a PDF, but it is written in German.
Is that what you meant?
Literaturverwaltung in Zotero_IdBH_v0.30.pdf

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Nov 22, 2023
…omy-in-the-construction-and-wood-industry-idbh.csl

Adding the description in the directory of categories "post, post-weblog"
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

bern-university-of-applied-sciences-institute-for-digital-economy-in-the-construction-and-wood-industry-idbh.csl (new)
(“CSL search by example,” 2012; Hancké et al., 2007)
(Fenner et al., 2019; Mares, 2001)

CSL search by example [online publication], 2012. [online publication]. Citation Style Editor. http://editor.citationstyles.org/searchByExample/ (accessed on 15.12.2012).
Fenner, M., Crosas, M., Grethe, J.S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., Clark, T., 2019. A data citation roadmap for scholarly data repositories. Sci. Data 6 - edition 1, pages 28. https://doi.org/10.1038/s41597-019-0031-8.
Hancké, B., Rhodes, M., Thatcher, M. (Eds.), 2007. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press, Oxford and New York.
Mares, I., 2001. Firms and the welfare state: When, why, and how does social policy matter to employers?, Oxford University Press, in: Hall, P.A., Soskice, D. (Eds.), Varieties of Capitalism. The Institutional Foundations of Comparative Advantage. Oxford University Press, New York, pp. pages 184–213.

…omy-in-the-construction-and-wood-industry-idbh.csl

add updated "Date"
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

bern-university-of-applied-sciences-institute-for-digital-economy-in-the-construction-and-wood-industry-idbh.csl (new)
(“CSL search by example,” 2012; Hancké et al., 2007)
(Fenner et al., 2019; Mares, 2001)

CSL search by example [online publication], 2012. [online publication]. Citation Style Editor. http://editor.citationstyles.org/searchByExample/ (accessed on 15.12.2012).
Fenner, M., Crosas, M., Grethe, J.S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., Clark, T., 2019. A data citation roadmap for scholarly data repositories. Sci. Data 6 - edition 1, pages 28. https://doi.org/10.1038/s41597-019-0031-8.
Hancké, B., Rhodes, M., Thatcher, M. (Eds.), 2007. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press, Oxford and New York.
Mares, I., 2001. Firms and the welfare state: When, why, and how does social policy matter to employers?, Oxford University Press, in: Hall, P.A., Soskice, D. (Eds.), Varieties of Capitalism. The Institutional Foundations of Comparative Advantage. Oxford University Press, New York, pp. pages 184–213.

…omy-in-the-construction-and-wood-industry-idbh.csl

adding the attribute "supervised" to dissertations
Copy link

😟 There are some issues with your submission.

2 tests failed

bern-university-of-applied-sciences-institute-for-digital-economy-in-the-construction-and-wood-industry-idbh: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[0, "292:3: FATAL: Extra content at the end of the document"]].empty?` to be truthy, got false

bern-university-of-applied-sciences-institute-for-digital-economy-in-the-construction-and-wood-industry-idbh: may not have any unused macros

expected: []
     got: ["access", "author-IdBH", "author-short-IdBH", "container", "issued", "locators"]

(compared using ==)

Please check the test report for details.

…omy-in-the-construction-and-wood-industry-idbh.csl
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

bern-university-of-applied-sciences-institute-for-digital-economy-in-the-construction-and-wood-industry-idbh.csl (new)
(“CSL search by example,” 2012; Hancké et al., 2007)
(Fenner et al., 2019; Mares, 2001)

CSL search by example [online publication], 2012. [online publication]. Citation Style Editor. http://editor.citationstyles.org/searchByExample/ (accessed on 15.12.2012).
Fenner, M., Crosas, M., Grethe, J.S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., Clark, T., 2019. A data citation roadmap for scholarly data repositories. Sci. Data 6 - edition 1, pages 28. https://doi.org/10.1038/s41597-019-0031-8.
Hancké, B., Rhodes, M., Thatcher, M. (Eds.), 2007. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press, Oxford and New York.
Mares, I., 2001. Firms and the welfare state: When, why, and how does social policy matter to employers?, Oxford University Press, in: Hall, P.A., Soskice, D. (Eds.), Varieties of Capitalism. The Institutional Foundations of Comparative Advantage. Oxford University Press, New York, pp. pages 184–213.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The supervisors were added for the thesis

@BFH-wht2
Copy link
Author

Hello,
I wanted to ask what else I need to do so that this style can be published?
So that it can then be downloaded by people.
Thank you in advance!

…omy-in-the-construction-and-wood-industry-idbh.csl

The style has been finalised by me, needs a review and could then be published in public.
Thanks in advance!
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

bern-university-of-applied-sciences-institute-for-digital-economy-in-the-construction-and-wood-industry-idbh.csl (new)
(“CSL search by example,” 2012; Hancké et al., 2007)
(Fenner et al., 2019; Mares, 2001)

CSL search by example [online publication], 2012. [online publication]. Citation Style Editor. http://editor.citationstyles.org/searchByExample/ (accessed on 15.12.2012).
Fenner, M., Crosas, M., Grethe, J.S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., Clark, T., 2019. A data citation roadmap for scholarly data repositories. Sci. Data 6 - edition 1, pages 28. https://doi.org/10.1038/s41597-019-0031-8.
Hancké, B., Rhodes, M., Thatcher, M. (Eds.), 2007. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press, Oxford and New York.
Mares, I., 2001. Firms and the welfare state: When, why, and how does social policy matter to employers?, Oxford University Press, in: Hall, P.A., Soskice, D. (Eds.), Varieties of Capitalism. The Institutional Foundations of Comparative Advantage. Oxford University Press, New York, pp. pages 184–213.

Copy link
Member

@bwiernik bwiernik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience. A few initial things to fix

Comment on lines +293 to +298
<if type="thesis" match="any">
<text value="supervised by: " prefix=" ("/>
<group delimiter=", " suffix=").">
<names variable="contributor"/>
</group>
</if>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<if type="thesis" match="any">
<text value="supervised by: " prefix=" ("/>
<group delimiter=", " suffix=").">
<names variable="contributor"/>
</group>
</if>
<if type="thesis" match="any">
<names variable="contributor" prefix="(supervised by: " suffix=")"/>
</if>

<title>BFH-AHB_Deutsch</title>
<title-short>BFH-AHB (De)</title-short>
<id>http://www.zotero.org/styles/bern-university-of-applied-sciences-institute-for-digital-economy-in-the-construction-and-wood-industry-idbh</id>
<link href="http://www.zotero.org/styles/bern-university-of-applied-sciences-institute-for-digital-economy-in-the-construction-and-wood-industry-idbh" rel="self"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a link to documentation for the style

<?xml version="1.0" encoding="utf-8"?>
<style xmlns="http://purl.org/net/xbiblio/csl" class="in-text" version="1.0" demote-non-dropping-particle="never" default-locale="en-US">
<info>
<!-- version "BFH-AHB_11-23_Deutsch; Elsevier - Harvard (author-date)", wht2 -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- version "BFH-AHB_11-23_Deutsch; Elsevier - Harvard (author-date)", wht2 -->

Comment on lines +5 to +6
<title>BFH-AHB_Deutsch</title>
<title-short>BFH-AHB (De)</title-short>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spell out the title in full following the requirements here: https://github.com/citation-style-language/styles/blob/master/STYLE_REQUIREMENTS.md

Also, the title says "Deutsch" but the default locale is "en-US" and the various hardcoded words in the style are in English. Please correct whichever of those is incorrect.

</group>
</else-if>
<else-if type="chapter paper-conference" match="any">
<group delimiter=", " prefix=". ">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Throughout the style, you have a lot of punctuation in prefixes and suffixes. This creates high risk for extra punctuation being added when variables are missing. Please go through the style and replace these with <group delimiter=". "> and similar so that punctuation only appears when necessary.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants