Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create bibliotheca-hertziana-max-planck-institute-for-art-history.csl #6525

Merged
merged 14 commits into from
Jan 17, 2024
Merged

Create bibliotheca-hertziana-max-planck-institute-for-art-history.csl #6525

merged 14 commits into from
Jan 17, 2024

Conversation

hawkenbury
Copy link
Contributor

Initial Commit : Bibliotheca Hertziana Max Planck Institute for Art History

@hawkenbury
Create bibliotheca-hertziana-max-planck-institute-for-art-history.csl
73e5afa 
Initial Commit : Bibliotheca Hertziana Max Planck Institute for Art History
@github-actions
Copy link

github-actions bot commented May 4, 2023

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@github-actions
Copy link

github-actions bot commented May 4, 2023

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

bibliotheca-hertziana-max-planck-institute-for-art-history.csl (new)
Beyond varieties of capitalism, 2007, “CSL search by example”, 2012
Mares 2001, Fenner/Crosas/Grethe/Kennedy/Hermjakob/Rocca-Serra/Durand/Berjon/Karcher/Martone/Clark 2019
Beyond varieties of capitalism, ed. Bob Hancké, Martin Rhodes and Mark Thatcher, Oxford University Press, Oxford and New York,2007.
“CSL search by example”, This reference type is not currently supportedhttp://editor.citationstyles.org/searchByExample/. Accessed December 15, 2012
Martin Fenner, Mercè Crosas, Jeffrey S Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, Maryann Martone, and Tim Clark, , “A data citation roadmap for scholarly data repositories”, Scientific Data, vol. 6, 1, (2019), p. 28. URL: http://www.nature.com/articles/s41597-019-0031-8.
Isabela Mares, , “Firms and the welfare state: When, why, and how does social policy matter to employers?”, in Varieties of capitalism. The institutional foundations of comparative advantage, ed. Peter A. Hall and David Soskice, Oxford University Press, New York, 2001, pp. 184–213.

@adam3smith adam3smith mentioned this pull request May 5, 2023
Closed
hawkenbury
hawkenbury commented May 16, 2023
View reviewed changes
Copy link
Contributor Author

@hawkenbury hawkenbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added full-stop to initials in authors macro

@github-actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

bibliotheca-hertziana-max-planck-institute-for-art-history.csl (new)
Beyond varieties of capitalism, 2007, “CSL search by example”, 2012
Mares 2001, Fenner/Crosas/Grethe/Kennedy/Hermjakob/Rocca-Serra/Durand/Berjon/Karcher/Martone/Clark 2019
Beyond varieties of capitalism, ed. Bob Hancké, Martin Rhodes and Mark Thatcher, Oxford University Press, Oxford and New York,2007.
“CSL search by example”, This reference type is not currently supportedhttp://editor.citationstyles.org/searchByExample/. Accessed December 15, 2012
Martin Fenner, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, Maryann Martone, and Tim Clark, , “A data citation roadmap for scholarly data repositories”, Scientific Data, vol. 6, 1, (2019), p. 28. URL: http://www.nature.com/articles/s41597-019-0031-8.
Isabela Mares, , “Firms and the welfare state: When, why, and how does social policy matter to employers?”, in Varieties of capitalism. The institutional foundations of comparative advantage, ed. Peter A. Hall and David Soskice, Oxford University Press, New York, 2001, pp. 184–213.

@hawkenbury
Copy link
Contributor Author

Hi,
Do I need to do anything else for this to be published?

Best Wishes
Chris

@github-actions GitHub Actions
Copy link

😟 There are some issues with your submission.

2 tests failed

bibliotheca-hertziana-max-planck-institute-for-art-history: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[8, "8:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [17, "17:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

bibliotheca-hertziana-max-planck-institute-for-art-history: must be parsable as a CSL style

not allowed to add #<CSL::Style::Group display="block" children=[2]> to #<struct CSL::Style::Bibliography::Children sort=nil, layout=nil>

Please check the test report for details.

@github-actions GitHub Actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

bibliotheca-hertziana-max-planck-institute-for-art-history.csl (new)
Beyond varieties of capitalism, 2007, “CSL search by example”, 2012
Mares 2001, Fenner/Crosas/Grethe/Kennedy/Hermjakob/Rocca-Serra/Durand/Berjon/Karcher/Martone/Clark 2019
Beyond varieties of capitalism, ed. Bob Hancké, Martin Rhodes and Mark Thatcher, Oxford University Press, Oxford and New York,2007.
“CSL search by example”, This reference type is not currently supportedhttp://editor.citationstyles.org/searchByExample/. Accessed December 15, 2012
Martin Fenner, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, Maryann Martone, and Tim Clark, , “A data citation roadmap for scholarly data repositories”, Scientific Data, vol. 6, 1, (2019), p. 28. URL: http://www.nature.com/articles/s41597-019-0031-8.
Isabela Mares, , “Firms and the welfare state: When, why, and how does social policy matter to employers?”, in Varieties of capitalism. The institutional foundations of comparative advantage, ed. Peter A. Hall and David Soskice, Oxford University Press, New York, 2001, pp. 184–213.

@github-actions GitHub Actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

bibliotheca-hertziana-max-planck-institute-for-art-history.csl (new)
Beyond varieties of capitalism, 2007, CSL search by example, 2012
Mares 2001, Fenner et al. 2019
Fenner et al. 2019
Martin Fenner, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, Maryann Martone, and Tim Clark, , “A data citation roadmap for scholarly data repositories”, Scientific Data, vol. 6, 1, (2019), p. 28. URL: http://www.nature.com/articles/s41597-019-0031-8.
Mares 2001
Isabela Mares, , “Firms and the welfare state: When, why, and how does social policy matter to employers?”, in Varieties of capitalism. The institutional foundations of comparative advantage, ed. Peter A. Hall and David Soskice, Oxford University Press, New York, 2001, pp. 184–213.
CSL search by example, 2012
This reference type is not currently supportedhttp://editor.citationstyles.org/searchByExample/. Accessed December 15, 2012
Beyond varieties of capitalism, 2007
Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, ed. Bob Hancké, Martin Rhodes and Mark Thatcher, Oxford University Press, Oxford and New York,2007.

@github-actions GitHub Actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

bibliotheca-hertziana-max-planck-institute-for-art-history.csl (new)
Beyond varieties of capitalism, 2007, CSL search by example, 2012
Mares 2001, Fenner et al. 2019
Fenner et al. 2019
Martin Fenner, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, Maryann Martone and Tim Clark “A data citation roadmap for scholarly data repositories”, Scientific Data, vol. 6, 1, (2019), p. 28. URL: http://www.nature.com/articles/s41597-019-0031-8.
Mares 2001
Isabela Mares “Firms and the welfare state: When, why, and how does social policy matter to employers?”, in Varieties of capitalism. The institutional foundations of comparative advantage, ed. Peter A. Hall, David Soskice, Oxford University Press, New York, 2001, pp. 184–213.
CSL search by example, 2012
This reference type is not currently supportedhttp://editor.citationstyles.org/searchByExample/. Accessed December 15, 2012
Beyond varieties of capitalism, 2007
Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, ed. Bob Hancké, Martin Rhodes, Mark Thatcher, Oxford University Press, Oxford and New York,2007.

@github-actions GitHub Actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

bibliotheca-hertziana-max-planck-institute-for-art-history.csl (new)
Beyond varieties of capitalism, 2007, CSL search by example, 2012
Mares 2001, Fenner et al. 2019
Fenner et al. 2019
Martin Fenner, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, Maryann Martone and Tim Clark “A data citation roadmap for scholarly data repositories”, Scientific Data, vol. 6, 1, (2019), p. 28. URL: http://www.nature.com/articles/s41597-019-0031-8. DOI: https://doi.org/10.1038/s41597-019-0031-8
Mares 2001
Isabela Mares “Firms and the welfare state: When, why, and how does social policy matter to employers?”, in Varieties of capitalism. The institutional foundations of comparative advantage, ed. Peter A. Hall, David Soskice, Oxford University Press, New York, 2001, pp. 184–213.
CSL search by example, 2012
This reference type is not currently supportedhttp://editor.citationstyles.org/searchByExample/. Accessed December 15, 2012
Beyond varieties of capitalism, 2007
Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, ed. Bob Hancké, Martin Rhodes, Mark Thatcher, Oxford University Press, Oxford and New York,2007.

adam3smith
adam3smith requested changes Nov 21, 2023
View reviewed changes
Copy link
Member

@adam3smith adam3smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay -- some questions, some things you'd need to fix.

bibliotheca-hertziana-max-planck-institute-for-art-history.csl Outdated
<term name="close-quote">”</term>
<term name="open-inner-quote">‘</term>
<term name="close-inner-quote">’</term>
<term name="page-range-delimiter">&#8211;</term>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<term name="page-range-delimiter">&#8211;</term>

this is already set to an en-dash

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

bibliotheca-hertziana-max-planck-institute-for-art-history.csl Outdated
<group delimiter=":">
<group delimiter=" ">
<text macro="contributors-short"/>
<group delimiter="; ">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this group (it doesn't actually do anything). Also, you really want "dimensions" there are as a variable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

bibliotheca-hertziana-max-planck-institute-for-art-history.csl Outdated
<names variable="author">
<name form="short" delimiter=" / " delimiter-precedes-et-al="never" delimiter-precedes-last="always" et-al-min="4" et-al-use-first="1"/>
<substitute>
<group>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're sure you don't want editor in here? It's very unusual to cite an edited volume by its title rather than by its editors.
Ditto for the author macro above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the style that the institution wants - the rules are complicated but this is correct

bibliotheca-hertziana-max-planck-institute-for-art-history.csl Show resolved Hide resolved
bibliotheca-hertziana-max-planck-institute-for-art-history.csl Show resolved Hide resolved
bibliotheca-hertziana-max-planck-institute-for-art-history.csl Outdated
</group>
<date date-parts="year" form="text" variable="issued" suffix="."/>
<group delimiter=" ">
<label strip-periods="true" suffix=". " variable="page" form="short"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please clean up the strip-periods -- suffix="." combinations throughout -- you're removing periods and putting them back in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

bibliotheca-hertziana-max-planck-institute-for-art-history.csl Outdated
<group delimiter=" ">
<group delimiter=", ">
<group>
<text value="Manuscript"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use a term for this; all item types are available as terms

bibliotheca-hertziana-max-planck-institute-for-art-history.csl Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

bibliotheca-hertziana-max-planck-institute-for-art-history.csl (new)
Beyond varieties of capitalism 2007, 2012
Mares 2001, Fenner et al. 2019
Fenner et al. 2019
Martin Fenner, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, Maryann Martone and Tim Clark “A data citation roadmap for scholarly data repositories”, Scientific Data, vol. 6, 1, (2019), p. 28. URL: http://www.nature.com/articles/s41597-019-0031-8. DOI: https://doi.org/10.1038/s41597-019-0031-8
Mares 2001
Isabela Mares “Firms and the welfare state: When, why, and how does social policy matter to employers?”, in Varieties of capitalism. The institutional foundations of comparative advantage, ed. Peter A. Hall, David Soskice, Oxford University Press, New York, 2001, pp. 184–213.
2012
“CSL search by example”, 2012. URL: http://editor.citationstyles.org/searchByExample/.http://editor.citationstyles.org/searchByExample/. Accessed December 15, 2012
Beyond varieties of capitalism 2007
Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, ed. Bob Hancké, Martin Rhodes, Mark Thatcher, Oxford University Press, Oxford and New York,2007.

@hawkenbury
Copy link
Contributor Author

hawkenbury commented Nov 22, 2023 via email

@adam3smith
Copy link
Member

OK, last thing -- any reason this is an in-text style? As I understand the style guide, the citations are placed into footnotes, so the style should be class="note"

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Nov 28, 2023
@github-actions GitHub Actions
Copy link

😟 There are some issues with your submission.

1 test failed

bibliotheca-hertziana-max-planck-institute-for-art-history: must have a "class" attribute that matches the "citation-format" attribute

expected: "in-text"
     got: "note"

(compared using ==)

Please check the test report for details.

@github-actions GitHub Actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

bibliotheca-hertziana-max-planck-institute-for-art-history.csl (new)
Beyond varieties of capitalism 2007, 2012
Mares 2001, Fenner et al. 2019
Fenner et al. 2019
Martin Fenner, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, Maryann Martone and Tim Clark “A data citation roadmap for scholarly data repositories”, Scientific Data, vol. 6, 1, (2019), p. 28. URL: http://www.nature.com/articles/s41597-019-0031-8. DOI: https://doi.org/10.1038/s41597-019-0031-8
Mares 2001
Isabela Mares “Firms and the welfare state: When, why, and how does social policy matter to employers?”, in Varieties of capitalism. The institutional foundations of comparative advantage, ed. Peter A. Hall, David Soskice, Oxford University Press, New York, 2001, pp. 184–213.
2012
“CSL search by example”, 2012. URL: http://editor.citationstyles.org/searchByExample/.http://editor.citationstyles.org/searchByExample/. Accessed December 15, 2012
Beyond varieties of capitalism 2007
Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, ed. Bob Hancké, Martin Rhodes, Mark Thatcher, Oxford University Press, Oxford and New York,2007.

@hawkenbury
Copy link
Contributor Author

hawkenbury commented Nov 28, 2023 via email

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Nov 28, 2023
@hawkenbury
Copy link
Contributor Author

Could this be reviewed please?

@hawkenbury
Copy link
Contributor Author

hawkenbury commented Jan 16, 2024 via email

@adam3smith adam3smith merged commit d348c8f into citation-style-language:master Jan 17, 2024
1 check passed
@adam3smith
Copy link
Member

Thanks & sorry for the delay

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Jan 17, 2024
@hawkenbury
Copy link
Contributor Author

hawkenbury commented Jan 17, 2024 via email

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Jan 17, 2024
@hawkenbury
Copy link
Contributor Author

hawkenbury commented Jan 19, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam3smith adam3smith Awaiting requested review from adam3smith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hawkenbury @adam3smith