Fix incorrect result of rdb_increment on overflow

The rdb_increment used to return err_status_ok when overflow has happened, which results in undesirable consequences in other parts of the code.
cisco · Apr 24, 2017 · f2ae5c3 · f2ae5c3
1 parent 6cae683
commit f2ae5c3
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/crypto/replay/rdb.c b/crypto/replay/rdb.c
@@ -130,8 +130,9 @@ rdb_add_index(rdb_t *rdb, uint32_t p_index) {
 err_status_t
 rdb_increment(rdb_t *rdb) {
 
-  if (rdb->window_start++ > 0x7fffffff)
+  if (rdb->window_start >= 0x7fffffff)
     return err_status_key_expired;
+  ++rdb->window_start;
   return err_status_ok;
 }