Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NX DME Path Handling/General Path Improvements #58

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

NX DME Path Handling/General Path Improvements #58

wants to merge 3 commits into from

Conversation

remingtonc
Copy link
Contributor

Turns out..not everything is an XPath!

Fixes #43

@remingtonc remingtonc added bug Something isn't working feature os/nx NX-OS labels May 27, 2020
@remingtonc remingtonc self-assigned this May 27, 2020
@miott
Copy link
Collaborator

miott commented May 27, 2020

Changing the API names, _xpath to _path, will break backward compatibility.

@remingtonc
Copy link
Contributor Author

@miott Agreed. Holding this in draft. Considering either:

  1. Not changing and just calling everything an XPath even if it's not correct.
  2. Introducing the breaking change and just bumping version to 2.x.
  3. Aliasing everything as _xpath for best of both worlds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@remingtonc remingtonc

Labels
bug Something isn't working feature os/nx NX-OS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NX-OS DME break in Path parsing
2 participants
@remingtonc @miott