Bump default CPU cores #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent frustrations like #68
|
@edigaryev both me, you and now @ryanbooker experienced the freezes with the default 2 CPUs. Let's bump the default to prevent bad experience when creating VMs from scratch. |
edigaryev
reviewed
May 18, 2022
Sources/tart/VM.swift
Outdated
| @@ -103,7 +103,8 @@ class VM: NSObject, VZVirtualMachineDelegate, ObservableObject { | |||
| // Create config | |||
| config = VMConfig( | |||
| hardwareModel: requirements.hardwareModel, | |||
| cpuCountMin: requirements.minimumSupportedCPUCount, | |||
| // allocate at least 4 CPUs because otherwise VMs are frequently freezing | |||
| cpuCountMin: max(4, requirements.minimumSupportedCPUCount), | |||
There was a problem hiding this comment.
I think we should preserve the cpuCountMin in the VM configuration and update the cpuCount instead, otherwise it won't be possible do reduce the amount of CPU cores via the tart set.
There was a problem hiding this comment.
Good catch! See 958febf
edigaryev
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent frustrations like #84