chore: check argument before save desc cache

cinit · Nov 25, 2023 · 5accac0 · 5accac0
1 parent a4ad03d
commit 5accac0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/app/src/main/java/io/github/qauxv/util/dexkit/DexKitTarget.kt b/app/src/main/java/io/github/qauxv/util/dexkit/DexKitTarget.kt
@@ -68,6 +68,10 @@ sealed class DexKitTarget {
     var descCache: String?
         get() = descCacheKey.value
         set(value) {
+            if (!value.isNullOrEmpty()) {
+                // check if the value is valid
+                DexMethodDescriptor(value)
+            }
             descCacheKey.value = value
         }
 

diff --git a/app/src/main/java/io/github/qauxv/util/dexkit/DexMethodDescriptor.java b/app/src/main/java/io/github/qauxv/util/dexkit/DexMethodDescriptor.java
@@ -66,6 +66,9 @@ public DexMethodDescriptor(String desc) {
         }
         int a = desc.indexOf("->");
         int b = desc.indexOf('(', a);
+        if (a < 0 || b < 0) {
+            throw new IllegalArgumentException(desc);
+        }
         declaringClass = desc.substring(0, a);
         name = desc.substring(a + 2, b);
         signature = desc.substring(b);