Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change "through: "X.X.X" to "through: "^2.3.8" #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jakeburden
Copy link

@jakeburden jakeburden commented Jul 10, 2016

Greetings Chris! 👋👋

I'm proposing this pull request because I've run into a bit of an issue. If this PR isn't the correct way to solve that, let me know, and I'll look towards other avenues.

I've made a boilerplate codebase, and it uses trumpet. Trumpet depends on html-select, which depends on cssauron.

It seems that with npm 3.10.x, if you run npm install in the boilerplate codebase after pulling it down, an old version of through gets installed since the only other package that uses through that I'm using is oppressor. This old version of through crashes the server.

Two things seem to fix it so far:

The first is that I've included through in the package.json for the boilerplate codebase. I'd rather not include through in the package.json since I never directly call or use it, but that seems to be the only fix for now.

The second way that seems to fix the issue is by giving through a version number in the package.json of cssauron. I'll be honest; I'm not entirely sure of what X.X.X does in the version field, so if this PR doesn't seem right to you, please let me know :)

Thanks for your time with making this module!

steps to reproduce my issue:

  1. use npm3 npm i npm@lastest -g
  2. git clone https://github.com/dsurgeons/ds-node-boilerplate
  3. remove through from the package.json (not through2)
  4. npm install
  5. npm run dev
  6. go to localhost:9090
  7. server crashes
  8. error is:
/Users/Jake/playgrounds/debug/node2/node_modules/cssauron/tokenizer.js:69
      stream.queue(token())
             ^

TypeError: stream.queue is not a function
    at Stream.onend (/Users/Jake/playgrounds/debug/node2/node_modules/cssauron/tokenizer.js:69:14)
    at Stream.stream.end (/Users/Jake/playgrounds/debug/node2/node_modules/through/index.js:43:9)
    at parse (/Users/Jake/playgrounds/debug/node2/node_modules/cssauron/index.js:45:6)
    at Plex._lang (/Users/Jake/playgrounds/debug/node2/node_modules/cssauron/index.js:7:12)
    at Plex.select (/Users/Jake/playgrounds/debug/node2/node_modules/html-select/index.js:82:39)
    at Trumpet._selectAll (/Users/Jake/playgrounds/debug/node2/node_modules/trumpet/index.js:97:18)
    at Trumpet.select (/Users/Jake/playgrounds/debug/node2/node_modules/trumpet/index.js:64:20)
    at /Users/Jake/playgrounds/debug/node2/index.js:202:27
    at Server.http.createServer (/Users/Jake/playgrounds/debug/node2/index.js:102:5)
    at emitTwo (events.js:106:13)

@joost-de-vries
Copy link

I'm running into the same issue.

@thedailycommute
Copy link

I know this is an old problem, but it keeps coming back to bite us when (for whatever reason) we have to clean the ivy cache. And the solution is really (really!) simple!

The problem is in the "rev" attribute of the <dependency...> line in the file:

[...]\.ivy2\cache\org.webjars.npm\cssauron\ivy-1.4.0.xml

<dependency org="org.webjars.npm" name="through" rev="0" force="true" conf="compile->compile(*),master(compile);runtime->runtime(*)"/>

The attribute rev="0" should be replaced with rev="[0,)" and the problem is solved:

<dependency org="org.webjars.npm" name="through" rev="[0,)" force="true" conf="compile->compile(*),master(compile);runtime->runtime(*)"/>

Solved for as long as the .ivy2 cache is not deleted anyway.

Does anyone know how to get this correction propagated to the various repositories? It's a pain having to remember to find and edit this file after rebuilding the ivy cache...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants