change "through: "X.X.X" to "through: "^2.3.8" #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings Chris! 👋👋
I'm proposing this pull request because I've run into a bit of an issue. If this PR isn't the correct way to solve that, let me know, and I'll look towards other avenues.
I've made a boilerplate codebase, and it uses trumpet. Trumpet depends on html-select, which depends on cssauron.
It seems that with npm 3.10.x, if you run
npm install
in the boilerplate codebase after pulling it down, an old version ofthrough
gets installed since the only other package that usesthrough
that I'm using is oppressor. This old version ofthrough
crashes the server.Two things seem to fix it so far:
The first is that I've included
through
in the package.json for the boilerplate codebase. I'd rather not includethrough
in the package.json since I never directly call or use it, but that seems to be the only fix for now.The second way that seems to fix the issue is by giving
through
a version number in the package.json of cssauron. I'll be honest; I'm not entirely sure of what X.X.X does in the version field, so if this PR doesn't seem right to you, please let me know :)Thanks for your time with making this module!
steps to reproduce my issue:
npm i npm@lastest -g
through
from the package.json (notthrough2
)