Build compilation DB in a different way. #2299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzeller
force-pushed
the
feature-20241214-use-bant-compdb
branch
2 times, most recently
from
f3b8097 to
e36c791
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2299 +/- ##
==========================================
+ Coverage 92.93% 93.00% +0.07%
==========================================
Files 360 362 +2
Lines 26918 27272 +354
==========================================
+ Hits 25015 25364 +349
- Misses 1903 1908 +5 ☔ View full report in Codecov by Sentry. |
hzeller
force-pushed
the
feature-20241214-use-bant-compdb
branch
2 times, most recently
from
4127086 to
5bbbb92
Compare
hzeller
changed the title
hzeller
force-pushed
the
feature-20241214-use-bant-compdb
branch
from
8b11780 to
24a4786
Compare
The rules_compdb approach is not maintained anymore and does not work for newer bazel or modules bazel. The hedronvision way of creating a compilation DB was not working (chipsalliance#2261), so using `bant` now in this approach.
hzeller
force-pushed
the
feature-20241214-use-bant-compdb
branch
from
24a4786 to
8c554d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rules_compdb approach is not maintained anymore and does not work for newer bazel or modules bazel.
The hedronvision way of creating a compilation DB was not working (#2261), so using
bantnow in this approach.