LanguageServer Improve error messages in symbol table log #2080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Canonicalize one instance of creating an error message from fs::error * Filesystem messages: if there is an empty filename, explicitly show that. * UpwardFileSearch: provide more details in the emitted status.
If there are a bunch of issues (and for big or badly filelist configured
projects, there can be 10s of thousands), provide a summary of what messages
were encountered. Looks something like
```
1234 x NOT FOUND: Unable to reso...
233 x NOT FOUND: No member symb...
42 x ALREADY_EXISTS: foo/bar/b...
3 x INVALID_ARGUMENT: Syntax ...
```
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2080 +/- ##
==========================================
- Coverage 92.99% 92.97% -0.02%
==========================================
Files 358 358
Lines 26465 26474 +9
==========================================
+ Hits 24611 24615 +4
- Misses 1854 1859 +5 ☔ View full report in Codecov by Sentry. |
Only print entering and attempts to open a file as VLOG(2), and
report non-found as VLOG(1). That way it is easier to spot if an include
was not found.
In not-found status, don't record all include paths searched (this
can be a lot, thus a long string), just the number of paths searched.
Refine error reporting in file_util. Turns out that Windows returns
ESRCH ('no such process') when it doesn't find a file.
fangism
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a more detailed summary of VLOG() status print.
If there are a bunch of issues (and for big or badly filelist configured projects, there can be 10s of thousands), provide a summary of what messages were encountered.
Looks something like