Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some missing includes. #2070

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Add some missing includes. #2070

merged 1 commit into from
Jan 4, 2024

Conversation

hzeller
Copy link
Collaborator

@hzeller hzeller commented Jan 3, 2024

No description provided.

@hzeller hzeller requested a review from IEncinas10 January 3, 2024 19:15
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4e8133d) 92.95% compared to head (885040f) 92.95%.
Report is 17 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2070   +/-   ##
=======================================
  Coverage   92.95%   92.95%           
=======================================
  Files         358      358           
  Lines       26432    26442   +10     
=======================================
+ Hits        24569    24579   +10     
  Misses       1863     1863           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@IEncinas10 IEncinas10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! How did you notice this? I just quickly took some other rule as a reference, as it built I guessed it was ok.

I'll be more careful next time, but just wondering if there is any trick other than being really thorough :)

@hzeller
Copy link
Collaborator Author

hzeller commented Jan 4, 2024

Mostly eye-balling. There is a misc-include-cleaner in newer clang-tidy I believe, but that is too noisy at times.

@hzeller hzeller merged commit 7481743 into chipsalliance:master Jan 4, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants