Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Windows, use c++20 mode as correctly needed for designated initial… #2049

Merged
merged 1 commit into from
Dec 14, 2023
Merged

On Windows, use c++20 mode as correctly needed for designated initial… #2049

merged 1 commit into from
Dec 14, 2023

Conversation

hzeller
Copy link
Collaborator

@hzeller hzeller commented Dec 14, 2023

…izers.

Designated initializers is technically only supported starting with c++20, and the compiler on Windows points that out with an error.

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cfcbb82) 92.84% compared to head (b5e3b22) 92.84%.
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2049   +/-   ##
=======================================
  Coverage   92.84%   92.84%           
=======================================
  Files         357      357           
  Lines       26396    26396           
=======================================
  Hits        24507    24507           
  Misses       1889     1889           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…izers.

Designated initializers is technically only supported starting with c++20,
and the compiler on Windows points that out with an error.
@hzeller hzeller requested a review from fangism December 14, 2023 11:37
@hzeller hzeller merged commit 67d0888 into chipsalliance:master Dec 14, 2023
26 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants