-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
oops let me fix the commits edit: fixed |
2f57106
to
18aa413
Compare
I don't know if this is an existing bug, but if the menu is on the right side of the page, it overflows to the right. If that's an existing bug I'm okay merging this. I really think the "real" solution here is to use something like popper, which takes care of all of these annoying edge cases for us. |
Oooh right I didn't think of that. Let me look into it now and implement it within this |
@robbieaverill @ScopeyNZ setting up vue-popperjs, despite it using deprecated Either way, works with the deprecated slot syntax name |
implemented vue-popperjs, using forked version accepting showPopperDefault prop initialize showPopper state of vue-popperjs . (https://github.com/john-raymon/vue-popper/blob/76cc42c971f799cbd5c717b5bb33ae90a9ab61ea/src/component/popper.js.vue#L266) |
added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The menus don't have alignment any more - for example, there's a "right aligned" story for the options menu, but all of the menus show up below the toggle, evenly spaced either side of it.
Otherwise, I would suggest being careful using libraries with low popularity - they're likely to not be well maintained (for example, this library hasn't had any commits this year, and the issue you linked hasn't has a maintainer respond to it).
Was using popper.js directly not an option?
272b21a
to
33d4afe
Compare
Temporarily not center aligning below the button, but it's working with popper.js now respecting overflow and flipping too if necessary. |
9eafde9
to
fffc35a
Compare
…of basepopover, remove redundant code expecting left position prop
*using forked version accepting showPopperDefault prop initialize showPopper state of vue-popperjs <popper>
to match Figma designs
fffc35a
to
4c2ee4b
Compare
relative
withstatic
position on root ChecOptionsMenu element to allow popping out of BasePopover, removes need ofleft
position, makes it default positioning without needing to specifyleft
. (not sure if should also remove the require method, using the include, now it only accepts one value)https://deploy-preview-83--angry-joliot-6c09db.netlify.com/?path=/story/components-options-menu--default-story