msys2-cn@20241208: fix cannot be recognized by ridk #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All changes look good. Wait for review from human collaborators. msys2-cn
|
chawyehsu
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ruby Installerrelies on the
scoop prefix msys2command to ascertain whether MSYS2 has been installed via Scoop. This detection method, however, fails to recognize the variant namedmsys2-cnin this bucket, leading to unsuccessful detection. Consequently, despite MSYS2 being installed, the installer cannot locate it and erroneously concludes that "MSYS2 seems to be unavailable."https://github.com/oneclick/rubyinstaller2/blob/ff06a60e42f98807b2d1329d6774cf6c72074157/lib/ruby_installer/build/msys2_installation.rb#L48-L104
The modification is to add an environment variable so that the installer can recognize msys2-cn in
MSYS2_PATH.