Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix and continuously validate SBOMs #962

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented Nov 17, 2023

This runs the NTIA conformance checker on SBOMs produced by apko in CI.

This surfaced quite a lot of non-conformant behavior, which I've tried to clean up as best I can.

@imjasonh imjasonh changed the title WIP: fix and continuously validate SBOMs fix and continuously validate SBOMs Nov 17, 2023
@imjasonh imjasonh marked this pull request as ready for review November 17, 2023 18:04
Copy link
Member

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 🆒

@hectorj2f
Copy link
Member

I can think of an attestation for the images with the output of the ntia conformance test. Wdyt?

@mattmoor
Copy link
Member

I can think of an attestation for the images with the output of the ntia conformance test

I'm kinda 👎 on this, since it's something that should be a trivially verifiable property of the SBOM.

Signed-off-by: Jason Hall <[email protected]>
@imjasonh imjasonh enabled auto-merge November 17, 2023 19:21
@imjasonh imjasonh merged commit 7fac2ad into chainguard-dev:main Nov 17, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants