Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop support for CycloneDX SBOMs #961

Closed
wants to merge 1 commit into from

Conversation

imjasonh
Copy link
Member

Despite CycloneDX being described as one of the default SBOM formats, when publishing, we pick the first one (which is spdx by default) and publish that only.

apko/pkg/build/oci/sbom.go

Lines 153 to 157 in 4f9a4c6

if len(matched) > 1 {
// When we have multiple formats, warn that we're picking the first.
logger.Warnf("multiple SBOM formats requested, uploading SBOM with media type: %s", mt)
}
path = matched[0].Path

As a result, this code path is effectively never used (by Chainguard, at least), and since there are no tests or validation we have no idea whether this works or will continue to. Instead of having effectively dead code, let's just remove it.

TF-apko already only supports SPDX (ref)

@imjasonh
Copy link
Member Author

On second thought, let's not go to Camelot. 'Tis a silly place.

@imjasonh imjasonh closed this Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant