cleanup: remove unused flags #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Hall <[email protected]>
cpanato
approved these changes
Oct 31, 2023
andros21
added a commit
to andros21/actions
that referenced
this pull request
Nov 2, 2023
See chainguard-dev/apko#942 Signed-off-by: andros21 <[email protected]>
|
I was using the --skip-tags and --package-version-* flags. :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our move toward Terraform-based image builds, we no longer use a number of flags we had previously used -- mainly around tagging.
This PR drops some flags we don't use anymore, in an attempt to delay the implacable advance of entropy that lies at the heart of the human experience.
--stage-tagsused to skip tagging -- now we just invoke the build and tag later withoci_tag--use-docker-mediatypesused to use Docker-style media types -- now we just always publish OCI images--package-version-tag,--package-version-tag-stem,--package-version-tag-prefix,--tag-suffixall used to control version-tagging logic in apko; now we do this version string extraction and tagging inapko_tagsandoci_tagThis also unexports
GenerateOSReleasewhich was only ever called from the same package.No tests were harmed in the removal of this behavior. 🙃