Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the make-devenv.sh script #906

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

debasishbsws
Copy link
Member

Fixes #605

Maybe for some recent changes in apko this script was not working.

What I did:

  1. in the previous alpine:3.16.0 when we try apk add go it is getting the go-1.19.2 version but in order to run apko we need go-1.21.*. As I found it in the edge repository, So I have updated the BUILDER_ALPINE_TAG.
  2. Currently due to multi-architecture build all the image that we create, the arch name is appended into the image tag. And there is no image with the name apko-inception:latest. And for dev-env it is unnecessary to build for all the architecture.
  • Identify the current host architecture. and build only for that.
  • Replace the Image name with the proper one.

Signed-off-by: debasishbsws <[email protected]>
@Elizafox
Copy link
Contributor

LGTM 👍

@Elizafox Elizafox merged commit 69172d9 into chainguard-dev:main Oct 26, 2023
17 checks passed
@debasishbsws debasishbsws deleted the fix-make-devenv branch October 28, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make devenv, no such image
2 participants