change type structs encoding tag to json #648
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshrwolf
force-pushed
the
yaml-to-json-encoding
branch
from
1c7de3b to
46ad436
Compare
joshrwolf
force-pushed
the
yaml-to-json-encoding
branch
2 times, most recently
from
4de02ee to
db72872
Compare
Signed-off-by: Josh Wolf <[email protected]>
joshrwolf
force-pushed
the
yaml-to-json-encoding
branch
from
db72872 to
d87e051
Compare
|
@joshrwolf |
|
Can this be closed now, since #933 merged? |
|
close it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes the struct types encoding to
json. this does not change apko's config to be json based, but uses json as the common denominator of the two to appease external parsers that live injsonland (like the json schema format used by schemastore).This works assuming apko doesn't use any
yamlspecific syntax, which I'm guessing it doesn't, but please correct me if I'm wrong!The encoding is fairly simple, but I did my best to add/remove
omitemptywhere necessary.This PR is related to wolfi-dev/wolfictl#190