review feedback

Signed-off-by: Jason Hall <[email protected]>
chainguard-dev · Nov 17, 2023 · 0f044ab · 0f044ab
1 parent 58ec1e4
commit 0f044ab
Showing 1 changed file with 13 additions and 54 deletions.
diff --git a/.github/workflows/build-samples.yml b/.github/workflows/build-samples.yml
@@ -22,20 +22,17 @@ jobs:
           go-version-file: 'go.mod'
       - name: Setup QEMU
         uses: docker/setup-qemu-action@68827325e0b33c7199eb31dd4e31fbe9023e06e3 # v3.0.0
-
-      - name: build
-        run: |
+      - run: |
           make apko
-          ./apko version
-
-      - name: build image
-        timeout-minutes: 15
-        run: |
           ./apko build ./examples/nginx.yaml nginx:build /tmp/nginx-${{ matrix.arch }}.tar --debug --arch ${{ matrix.arch }}
 
       - name: Check SBOM Conformance
         run: |
           set -euxo pipefail
+          if ! ls *.spdx.json; then
+            echo "no SBOMs found!"
+            exit 1
+          fi
           for f in *.spdx.json; do
             echo ::group::sbom.json
             cat $f
@@ -53,17 +50,8 @@ jobs:
       - uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v2.1.5
         with:
           go-version-file: 'go.mod'
-      - name: Setup QEMU
-        uses: docker/setup-qemu-action@68827325e0b33c7199eb31dd4e31fbe9023e06e3 # v3.0.0
-
-      - name: build
-        run: |
+      - run: |
           make apko
-          ./apko version
-
-      - name: build image
-        timeout-minutes: 15
-        run: |
           ./apko build ./examples/nginx.yaml nginx:build /tmp/nginx.tar --debug
 
       - name: Check SBOM Conformance
@@ -88,16 +76,9 @@ jobs:
       - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
       - uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v2.1.5
         with:
-          go-version: "1.21"
-          check-latest: true
-      - name: build
-        run: |
+          go-version-file: 'go.mod'
+      - run: |
           make apko
-          ./apko version
-
-      - name: build images
-        timeout-minutes: 15
-        run: |
           for cfg in $(find ./examples/ -name '*.yaml'); do
             name=$(basename ${cfg} .yaml)
             ./apko build ${cfg} ${name}:build /tmp/${name}.tar --debug --arch amd64
@@ -111,26 +92,16 @@ jobs:
       - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
       - uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v2.1.5
         with:
-          go-version: "1.21"
-          check-latest: true
-      - name: Setup QEMU
-        uses: docker/setup-qemu-action@68827325e0b33c7199eb31dd4e31fbe9023e06e3 # v3.0.0
-
-      - name: build
-        run: |
-          make apko
-          ./apko version
-
+          go-version-file: 'go.mod'
       - uses: chainguard-dev/actions/setup-registry@main
         with:
           port: 5000
 
       - name: build image (w/ source date epoch)
-        shell: bash
-        timeout-minutes: 15
         env:
           SOURCE_DATE_EPOCH: "0"
         run: |
+          make apko
           FIRST=$(./apko publish ./examples/alpine-base.yaml localhost:5000/alpine 2> /dev/null)
 
           for idx in {2..10}
@@ -153,24 +124,14 @@ jobs:
       - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
       - uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v2.1.5
         with:
-          go-version: "1.21"
-          check-latest: true
-      - name: Setup QEMU
-        uses: docker/setup-qemu-action@68827325e0b33c7199eb31dd4e31fbe9023e06e3 # v3.0.0
-
-      - name: build
-        run: |
-          make apko
-          ./apko version
-
+          go-version-file: 'go.mod'
       - uses: chainguard-dev/actions/setup-registry@main
         with:
           port: 5000
 
       - name: build image (w/ build date epoch)
-        shell: bash
-        timeout-minutes: 15
         run: |
+          make apko
           # Without SOURCE_DATE_EPOCH set, the timestamp of the image will be computed to be
           # the maximum build date of the resolved APKs.
           FIRST=$(./apko publish ./examples/alpine-base.yaml localhost:5000/alpine 2> /dev/null)
@@ -200,10 +161,8 @@ jobs:
       - uses: chainguard-dev/actions/setup-registry@main
         with:
           port: 5000
-      - name: build
-        run: |
+      - run: |
           make apko
-          ./apko version
 
           # Build image with annotations.
           ref=$(./apko publish ./examples/nginx.yaml localhost:5000/nginx)