fix: check empty changelog, when empty throw error

cfug · Jun 12, 2023 · ac6f720 · ac6f720
1 parent e441695
commit ac6f720
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 2.1.2
+
+- Fix: Check empty changelog.
+
 ## 2.1.1
 
 - Fix: throw error when changelog is `*None.*`.

diff --git a/lib/src/commiter.dart b/lib/src/commiter.dart
@@ -39,12 +39,20 @@ class PkgCommiter {
       newVersion,
     );
 
-    if (currentVersionChangeLog == noneChangeLogText) {
+    if (currentVersionChangeLog.toLowerCase() ==
+        noneChangeLogText.toLowerCase()) {
       error(
         'No changelog for version $newVersion, current changelog is $currentVersionChangeLog',
       );
       setFailed('No changelog for version $newVersion');
     }
+
+    if (currentVersionChangeLog.trim().isEmpty) {
+      error(
+        'No changelog for version $newVersion, current changelog is empty',
+      );
+      setFailed('No changelog for version $newVersion');
+    }
   }
 
   final commitUser = 'cfug-dev';

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,6 +1,6 @@
 name: action_dio_release
 description: For release package to github release page and upload to pub.dev.
-version: 2.1.1
+version: 2.1.2
 repository: https://github.com/cfug/dio_issue_release_action
 publish_to: none