This repository has been archived by the owner on Nov 7, 2022. It is now read-only.
all: accept MetricsExporters by implementation #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeke-em
force-pushed
the
prepare-for-metrics-exporters
branch
2 times, most recently
from
bd4d7d7 to
686d7af
Compare
odeke-em
added a commit
that referenced
this pull request
Jan 6, 2019
Added a Prometheus metrics exporter that allows
us to export metrics.
Its configuration is available under YAML field option
```yaml
exporters
prometheus:
<key>: <value>
```
where <key> could be any of
* address -- the address on which to run the Prometheus
scrape endpoint /metrics on
* const_labels -- labels that will be applied to each
metric that is exported
* namespace -- optionally if defined records metrics
under a specific namespace, leave it blank to preserve
the names of the proxied metrics (if that's the case)
This change uses the Prometheus metrics exporter
at github.com/orijtech/prometheus-go-metrics-exporter
which will be handed over to the OpenCensus community
whenever a repository is created under the
"census-ecosystem" organization.
Fixes #292
Depends on #294
Please fix the build. |
|
@songy23 please help me make a new release for OpenCensus-Proto as per census-instrumentation/opencensus-proto#161 $ GO111MODULE=on go get github.com/census-instrumentation/opencensus-proto@master contrib.go.opencensus.io/exporter/ocagent@master
go: finding github.com/census-instrumentation/opencensus-proto master
go: finding contrib.go.opencensus.io/exporter/ocagent master
go get: inconsistent versions:
contrib.go.opencensus.io/exporter/[email protected] from contrib.go.opencensus.io/exporter/ocagent@master requires github.com/census-instrumentation/[email protected] (not github.com/census-instrumentation/[email protected] from github.com/census-instrumentation/opencensus-proto@master) |
pjanotti
approved these changes
Jan 10, 2019
odeke-em
force-pushed
the
prepare-for-metrics-exporters
branch
from
686d7af to
d2f0713
Compare
odeke-em
added a commit
that referenced
this pull request
Jan 10, 2019
Added a Prometheus metrics exporter that allows
us to export metrics.
Its configuration is available under YAML field option
```yaml
exporters
prometheus:
<key>: <value>
```
where <key> could be any of
* address -- the address on which to run the Prometheus
scrape endpoint /metrics on
* const_labels -- labels that will be applied to each
metric that is exported
* namespace -- optionally if defined records metrics
under a specific namespace, leave it blank to preserve
the names of the proxied metrics (if that's the case)
This change uses the Prometheus metrics exporter
at github.com/orijtech/prometheus-go-metrics-exporter
which will be handed over to the OpenCensus community
whenever a repository is created under the
"census-ecosystem" organization.
Fixes #292
Depends on #294
ExportersFromYAMLConfig now returns metricsExporters too.
odeke-em
force-pushed
the
prepare-for-metrics-exporters
branch
from
d2f0713 to
e741b37
Compare
|
Thank you for the review @pjanotti! |
odeke-em
added a commit
that referenced
this pull request
Jan 10, 2019
Added a Prometheus metrics exporter that allows
us to export metrics.
Its configuration is available under YAML field option
```yaml
exporters
prometheus:
<key>: <value>
```
where <key> could be any of
* address -- the address on which to run the Prometheus
scrape endpoint /metrics on
* const_labels -- labels that will be applied to each
metric that is exported
* namespace -- optionally if defined records metrics
under a specific namespace, leave it blank to preserve
the names of the proxied metrics (if that's the case)
This change uses the Prometheus metrics exporter
at github.com/orijtech/prometheus-go-metrics-exporter
which will be handed over to the OpenCensus community
whenever a repository is created under the
"census-ecosystem" organization.
Fixes #292
Depends on #294
odeke-em
added a commit
that referenced
this pull request
Jan 10, 2019
Added a Prometheus metrics exporter that allows
us to export metrics.
Its configuration is available under YAML field option
```yaml
exporters
prometheus:
<key>: <value>
```
where <key> could be any of
* address -- the address on which to run the Prometheus
scrape endpoint /metrics on
* const_labels -- labels that will be applied to each
metric that is exported
* namespace -- optionally if defined records metrics
under a specific namespace, leave it blank to preserve
the names of the proxied metrics (if that's the case)
This change uses the Prometheus metrics exporter
at github.com/orijtech/prometheus-go-metrics-exporter
which will be handed over to the OpenCensus community
whenever a repository is created under the
"census-ecosystem" organization.
Fixes #292
Depends on #294
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExportersFromYAMLConfig now returns metricsExporters
if the underlying code implements exporter.MetricsExporter.