This repository has been archived by the owner on Dec 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 201
Exporter/OcAgent: Skeleton and workflow for worker thread. #1574
Merged
songy23
merged 1 commit into
census-instrumentation:master
from
songy23:agent-exporter-workflow
Dec 13, 2018
Merged
Exporter/OcAgent: Skeleton and workflow for worker thread. #1574
songy23
merged 1 commit into
census-instrumentation:master
from
songy23:agent-exporter-workflow
Dec 13, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
force-pushed
the
agent-exporter-workflow
branch
2 times, most recently
from
November 9, 2018 22:50
932c79d
to
b9d3f6d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1574 +/- ##
============================================
- Coverage 83.47% 83.01% -0.46%
+ Complexity 1813 1732 -81
============================================
Files 261 258 -3
Lines 8339 7978 -361
Branches 803 766 -37
============================================
- Hits 6961 6623 -338
+ Misses 1123 1120 -3
+ Partials 255 235 -20
Continue to review full report at Codecov.
|
songy23
force-pushed
the
agent-exporter-workflow
branch
3 times, most recently
from
November 13, 2018 21:13
b20fd24
to
16a1f6e
Compare
songy23
force-pushed
the
agent-exporter-workflow
branch
2 times, most recently
from
November 21, 2018 02:09
8e09853
to
04861f2
Compare
Friendly ping. I think we need to agree on the workflow before I move on to implementation. |
songy23
force-pushed
the
agent-exporter-workflow
branch
from
December 3, 2018 06:38
04861f2
to
39178cc
Compare
songy23
force-pushed
the
agent-exporter-workflow
branch
from
December 4, 2018 00:24
39178cc
to
9fe529c
Compare
PTAL. |
bogdandrutu
approved these changes
Dec 12, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skeleton looks good.
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #1492.
Updates #1408.