Skip to content
This repository has been archived by the owner on Dec 23, 2023. It is now read-only.

Exporter/OcAgent: Skeleton and workflow for worker thread. #1574

Merged

Conversation

songy23
Copy link
Contributor

@songy23 songy23 commented Nov 9, 2018

Split from #1492.

Updates #1408.

@songy23 songy23 requested a review from bogdandrutu November 9, 2018 22:34
@songy23 songy23 force-pushed the agent-exporter-workflow branch 2 times, most recently from 932c79d to b9d3f6d Compare November 9, 2018 22:50
@codecov-io
Copy link

codecov-io commented Nov 10, 2018

Codecov Report

Merging #1574 into master will decrease coverage by 0.45%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1574      +/-   ##
============================================
- Coverage     83.47%   83.01%   -0.46%     
+ Complexity     1813     1732      -81     
============================================
  Files           261      258       -3     
  Lines          8339     7978     -361     
  Branches        803      766      -37     
============================================
- Hits           6961     6623     -338     
+ Misses         1123     1120       -3     
+ Partials        255      235      -20
Impacted Files Coverage Δ Complexity Δ
...e/ocagent/OcAgentTraceServiceConnectionWorker.java 0% <0%> (ø) 0 <0> (?)
...java/io/opencensus/contrib/http/HttpExtractor.java 0% <0%> (-100%) 0% <0%> (-1%)
...census/trace/propagation/PropagationComponent.java 80% <0%> (-20%) 3% <0%> (ø)
...monitoredresource/util/MonitoredResourceUtils.java 14.28% <0%> (-16.97%) 1% <0%> (-1%)
...sus/implcore/trace/export/ExportComponentImpl.java 85% <0%> (-15%) 9% <0%> (-1%)
.../opencensus/impl/internal/DisruptorEventQueue.java 79.54% <0%> (-11.37%) 5% <0%> (-1%)
...rter/stats/stackdriver/StackdriverExportUtils.java 79.06% <0%> (-10.94%) 37% <0%> (-12%)
...src/main/java/io/opencensus/resource/Resource.java 82.75% <0%> (-8.36%) 14% <0%> (-8%)
...io/opencensus/contrib/zpages/ZPageHttpHandler.java 37.5% <0%> (-7.67%) 5% <0%> (ø)
...er/stats/stackdriver/StackdriverStatsExporter.java 66.66% <0%> (-4.59%) 12% <0%> (-2%)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72d3a9a...9fe529c. Read the comment docs.

@songy23 songy23 force-pushed the agent-exporter-workflow branch 3 times, most recently from b20fd24 to 16a1f6e Compare November 13, 2018 21:13
@songy23 songy23 force-pushed the agent-exporter-workflow branch 2 times, most recently from 8e09853 to 04861f2 Compare November 21, 2018 02:09
@songy23
Copy link
Contributor Author

songy23 commented Nov 21, 2018

Friendly ping. I think we need to agree on the workflow before I move on to implementation.

@songy23 songy23 force-pushed the agent-exporter-workflow branch from 39178cc to 9fe529c Compare December 4, 2018 00:24
@songy23
Copy link
Contributor Author

songy23 commented Dec 4, 2018

PTAL.

Copy link
Contributor

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skeleton looks good.

@songy23
Copy link
Contributor Author

songy23 commented Dec 13, 2018

Thanks!

@songy23 songy23 merged commit f47db4c into census-instrumentation:master Dec 13, 2018
@songy23 songy23 deleted the agent-exporter-workflow branch December 13, 2018 01:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants