Exporter/OCAgent: Add OcAgentNodeUtils. #1471
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1471 +/- ##
============================================
- Coverage 82.23% 82.17% -0.06%
- Complexity 1552 1564 +12
============================================
Files 239 240 +1
Lines 7266 7333 +67
Branches 682 687 +5
============================================
+ Hits 5975 6026 +51
- Misses 1082 1097 +15
- Partials 209 210 +1
Continue to review full report at Codecov.
|
|
Friendly ping @bogdandrutu |
| Timestamp censusTimestamp = Timestamp.fromMillis(System.currentTimeMillis()); | ||
| return Node.newBuilder() | ||
| .setIdentifier(getProcessIdentifier(jvmName, censusTimestamp)) | ||
| .setLibraryInfo(getLibraryInfo(OpenCensusLibraryInformation.VERSION)) |
There was a problem hiding this comment.
I think this exporter should have it's own version.
There was a problem hiding this comment.
Are you suggesting using a different version for this exporter in the LibraryInfo message, or using a different version even for releasing to Maven?
All other exporters have the same version as opencensus-api, having a different version only for this exporter may be confusing.
There was a problem hiding this comment.
If I compile the application with opencensus-api version 0.16 and opencensus-exporter-trace-ocagent version 0.17 I think this should be reflected in the proto that we send. So I suggest to have a VERSION string in the ocagent package which we update in the same way we update the one in the core library.
There was a problem hiding this comment.
Make sense to me, updated.
Add utilities for detecting and creating Node. Equivalent to https://github.com/census-ecosystem/opencensus-go-exporter-ocagent/blob/master/nodeinfo.go.
songy23
force-pushed
the
agent-exporter-impl-2
branch
from
382c21e to
64b6ef3
Compare
|
Thanks! |
Updates #1408.
Add utilities for detecting and creating Node.
Equivalent to https://github.com/census-ecosystem/opencensus-go-exporter-ocagent/blob/master/nodeinfo.go.