Split FaultProof initialization to new function initializeAnchorStateRegistry() #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Registry(). Don't deploy testing FP types
…ests and legacy systems
jcortejoso
force-pushed
the
jcortejoso/fault-proofs-deployment
branch
from
3d16ab7 to
4a7ecb6
Compare
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
|
@SocketSecurity ignore pypi/[email protected] |
palango
reviewed
Dec 17, 2024
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
jcortejoso
force-pushed
the
jcortejoso/fault-proofs-deployment
branch
from
83d2311 to
380a18f
Compare
|
What is meant by
Are those taken from step 1? |
palango
reviewed
Jan 10, 2025
| waitReachable(config.client.l1.public, 10_000), | ||
| waitReachable(config.client.l2.public, 10_000), | ||
| waitForNextGame(config.client.l1.public, chainConfig.l2, 60_000), | ||
| waitReachable(config.client.l1.public, 60_000), |
palango
reviewed
Jan 10, 2025
| @@ -1,5 +1,5 @@ | |||
| certifi==2024.7.4 | |||
| cffi==1.15.1 | |||
| cffi==1.17.1 | |||
There was a problem hiding this comment.
Also, related to the fault registry changes?
* mark it as executable * allow running on both MacOS and linux (GNU vs BSD tool differences) * terminate on errors * less strict go.mod matching to allow applying it directly to upstream
* [Automatic] - Update op-geth dependencies Update the go package dependency and the devnet docker container reference of the `l2` service to the latest commit (`0162ce9d029819807bcba2dc94875888c72aa88d`) in the `celo10` ref. * Adapt address-getters to op-geth library changes * Update cffi python package --------- Co-authored-by: Javier Cortejoso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR splits the FaultProof initialization to new function initializeAnchorStateRegistry(). Also removes the "testing" fault proof game times (Alphabet, Asterisc, Fast) that are not intended for production networks.
With these changes, L1 deployment process would look like:
Deploy.s.solrun() function as normally. With the changes, Fault Game implementations are not deployed, and AnchorStateRegistry is not initialized (and cannot be initialized at this point without registering a game by the admin, with errorexecution reverted: Proxy: implementation not initialized). Command to deploy the L1 contracts:Proceed with the deployment. Generate L2
genesis.jsonandrollup.json. Get theoutputRootfor the L2 migration block (or genesis if a new testnet) and replace the valuesfaultGameGenesisBlockandfaultGameGenesisOutputRootin the rollup config.Initialize the Fault Proofs, with the command: