Add unit tests for JSON and RLP encoding/decoding of Celo Transactions #306
+706
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kourin1996
changed the title
Kourin1996
commented
Jan 8, 2025
| @@ -37,6 +37,7 @@ func celoTransactionMarshal(tx *Transaction) ([]byte, bool, error) { | |||
| enc.Nonce = (*hexutil.Uint64)(&itx.Nonce) | |||
| enc.To = tx.To() | |||
| enc.Gas = (*hexutil.Uint64)(&itx.Gas) | |||
| enc.GasPrice = (*hexutil.Big)(itx.GasPrice) | |||
There was a problem hiding this comment.
I found one thing while I was writing a test:
Originally Celo's LegacyTx set null to gasPrice field on json marshaling. But Celo LegacyTx takes gasPrice field from JSON on unmarshaling. It causes mismatch after marshaling and unmarshaling.
Is this fix right? If no, I will remove this new line and do small fixes of unit tests
…-tx-encoding-decoding
Kourin1996
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #151
This PR adds tests for json and RLP encoding/decoding of the following Celo Tx types: