Add more verbosity to contract-address getter defaults #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the `GetAddresses` function silently returned the mainnet addresses as a default value, without the caller being made aware of this. Now, the `GetAddresses` function will return `nil` whenever it does not explicitly maps the passed in chain-id to a set of addresses. The newly added `GetAddressesOrDefault` function allows for retrieving the addresses with a default fallback for easier use in inline calls. This replicates the behavior of the old `GetAddresses` functionality with more verbosity.
palango
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the
GetAddressesfunction silently returned the mainnet addresses as a default value, without the caller being made aware of this.Now, the
GetAddressesfunction will returnnilwhenever it does not explicitly map the passed in chain-id to a set of addresses.The newly added
GetAddressesOrDefaultfunction allows for retrieving the addresses with a default fallback for easier use in inline calls. This replicates the behavior of the oldGetAddressesfunctionality with more verbosity.