Add minor code improvements

Co-authored-by: Paul Lange <[email protected]>

common/celo_types.go

@@ -25,6 +25,7 @@ func MaxAllowedIntrinsicGasCost(i IntrinsicGasCosts, feeCurrency *Address) (uint
 	// during execution
 	return intrinsicGas * 3, true
 }
+
 func CurrencyIntrinsicGasCost(i IntrinsicGasCosts, feeCurrency *Address) (uint64, bool) {
 	if feeCurrency == nil {
 		return 0, true

contracts/fee_currencies.go

@@ -141,7 +141,7 @@ func GetRegisteredCurrencies(caller *abigen.FeeCurrencyDirectoryCaller) ([]commo
 	return currencies, nil
 }
 
-// GetExchangeRates returns the exchange rates for the provided gas currencies from CELO
+// GetExchangeRates returns the exchange rates for the provided gas currencies
 func GetExchangeRates(caller bind.ContractCaller) (common.ExchangeRates, error) {
 	exchangeRates := map[common.Address]*big.Rat{}
 	directory, err := abigen.NewFeeCurrencyDirectoryCaller(addresses.FeeCurrencyDirectoryAddress, caller)
@@ -150,7 +150,7 @@ func GetExchangeRates(caller bind.ContractCaller) (common.ExchangeRates, error)
 	}
 	currencies, err := GetRegisteredCurrencies(directory)
 	if err != nil {
-		return map[common.Address]*big.Rat{}, err
+		return common.ExchangeRates{}, err
 	}
 	return getExchangeRatesForTokens(directory, currencies)
 }

core/bench_test.go

@@ -83,8 +83,7 @@ func genValueTx(nbytes int) func(int, *BlockGen) {
 	return func(i int, gen *BlockGen) {
 		toaddr := common.Address{}
 		data := make([]byte, nbytes)
-		var feeIntrinsic common.IntrinsicGasCosts
-		gas, _ := IntrinsicGas(data, nil, false, false, false, false, nil, feeIntrinsic)
+		gas, _ := IntrinsicGas(data, nil, false, false, false, false, nil, common.IntrinsicGasCosts{})
 		signer := gen.Signer()
 		gasPrice := big.NewInt(0)
 		if gen.header.BaseFee != nil {

tests/transaction_test_util.go

@@ -55,8 +55,7 @@ func (tt *TransactionTest) Run(config *params.ChainConfig) error {
 			return nil, nil, err
 		}
 		// Intrinsic gas
-		var feeIntrinsic common.IntrinsicGasCosts
-		requiredGas, err := core.IntrinsicGas(tx.Data(), tx.AccessList(), tx.To() == nil, isHomestead, isIstanbul, false, nil, feeIntrinsic)
+		requiredGas, err := core.IntrinsicGas(tx.Data(), tx.AccessList(), tx.To() == nil, isHomestead, isIstanbul, false, nil, common.IntrinsicGasCosts{})
 		if err != nil {
 			return nil, nil, err
 		}