-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compose caching functionality of LazySenseCalculator #1569
Compose caching functionality of LazySenseCalculator #1569
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nifty! (A test would be good.)
I think we don't have any tests for |
Test summary 4 215 files 6 517 suites 15m 1s ⏱️ Results for commit 5dacc44. ♻️ This comment has been updated with latest results. |
@esseivaju https://github.com/celeritas-project/celeritas/blob/develop/test/orange/univ/detail/SenseCalculator.test.cc ? I guess I missed that you didn't add a "lazy" calculator test in the previous PR. Could you please add both? |
Okay I think we're good now |
Comparing the previous develop run (6ec7f84):
and switching to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Great refactor, excellent parameterized test.
@esseivaju Did you happen to check whether the register/local usage changes? |
|
As discussed in #1565, have a simple
LazySenseCalculator
and a front-end with caching functionality. We could probably rework the original sense calculator as anEagerSenseCalculator
.