Fix: support f32 for longitudes and latitudes #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManonMarchand
force-pushed
the
feat-support-f32
branch
2 times, most recently
from
a4f5a11 to
20aecb9
Compare
this was working before numpy 2.0 since the conversion was done without us knowing
the dockers are really needed for the releases only
ManonMarchand
force-pushed
the
feat-support-f32
branch
from
20aecb9 to
b57720e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that we do a copy during the conversion. This was done silently before numpy 2.0. We now have to be explicit about it.
Fixes #35