Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working on combined merge of most open PRs #150

Merged
merged 18 commits into from
Oct 18, 2024
Merged

Working on combined merge of most open PRs #150

merged 18 commits into from
Oct 18, 2024

Conversation

chriku
Copy link
Contributor

@chriku chriku commented Oct 16, 2024

No description provided.

@chriku chriku changed the title Working on fullmerge of most open PRs Working on combined merge of most open PRs Oct 16, 2024
@chriku chriku force-pushed the working/fullmerge branch from cd8b4c9 to ab2987e Compare October 18, 2024 15:10
@chriku chriku marked this pull request as ready for review October 18, 2024 17:43
@chriku chriku requested a review from nk-coding October 18, 2024 17:43
val newUser = if (data.to != null) imsProject.ims().value.users()
.firstOrNull { (it.username == data.to) or (it.templatedFields["jira_id"] == encodedAccountId) } else null
if (newUser != null) {
val titleChangedEvent = (if (timelineId != null) service.neoOperations.findById<Assignment>(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

titleChangedEvent?
also maybe a bit long

@chriku chriku merged commit 80f2f32 into main Oct 18, 2024
1 check passed
@chriku chriku deleted the working/fullmerge branch October 18, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants