-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert small data sets to "static" versions #137
Comments
On the third point, why not use the static data in the vignettes? That would simplify things a great deal. |
@bryanhanson: thanks for spotting. I was thinking of the vignettes that import the real spectra. (Future) vignettes that are shipped with hyperSpec can and should use the data sets as in hyperSpec. related: #138 |
The description of the datasets may contain sentence, such as "The dataset is provided with the package is a subset of... (some real data)" To illustrate the ideas/functionality, we can even use artificial spectra. Just a thought, but maybe, some functions that simulate spectra could be included? |
I agree. But the links to the original dataset could also be provided. |
|
There is a |
Are the names of the new packages confirmed? Was there a discussion on that? I would prefer to have some shorter names as |
no, that discussion was postponed to the next video call (Monday 7 pm EEST). I opened an issue, though: #140 |
I'm doing some experimentation on this topic. There are some (in my opinion) unnecessary entries in |
I had not been experimenting with the data sets in this issue but with You are right that |
Fixed documentation - this closes the issue. |
Currently, hyperSpec generates its example data sets from real spectra files.
This is done during the building of the vignettes and comes at the cost of a non-standard building process with complex
Makefile
s (#132).As part of the general clean up
barbiturates
flu
laser
paracetamol
barbiturates
,laser
?)data-raw/
. Listdata-raw/
in.Rbuildignore
.see: https://r-pkgs.org/data.html#data-data
Makefile
s that create and copy these files into the package directory tree.gitignore
entries refering to them.The text was updated successfully, but these errors were encountered: