Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add browser export #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leonardlib
Copy link

No description provided.

@catdad
Copy link
Member

catdad commented Jul 26, 2024

Hello! Thanks for contributing.

Can you please elaborate what the purpose of this is? I am not seeing exports in the pacakge.json spec.

@leonardlib
Copy link
Author

leonardlib commented Jul 26, 2024

Hello! Thanks for contributing.

Can you please elaborate what the purpose of this is? I am not seeing exports in the pacakge.json spec.

Yup, sure!

I'm using the package as a module: import convert from 'heic-convert' and with TypeScript there is no problem because I'm using the @types/heic-convert package too.

But when I try to use the browser submodule: import convert from 'heic-convert/browser' with TypeScript, there is an error about missing type definitions, so I created the type definitions for the browser submodule: DefinitelyTyped/DefinitelyTyped#69983, but it also requires adding the exports field to the package.json to tell the NodeJS engine that there is submodule browser.

References:

@taylorhakes
Copy link

I am also running into this issue. Can this be merged?

@kyselberg
Copy link

this would be very helpful if merged

@BuZZ-dEE
Copy link

I had also this issue.

DefinitelyTyped/DefinitelyTyped#69573

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants