Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object tagging 33 #644

Closed
wants to merge 24 commits into from
Closed

Object tagging 33 #644

wants to merge 24 commits into from

Conversation

matthewhilton
Copy link
Contributor

@matthewhilton matthewhilton commented Oct 3, 2024

Cherry pick of #619 to MOODLE_33_STABLE

No major conflicts while cherry-picking, just namespacing and doc conflicts.

Testing

  • Objectfs unit tests passing locally
  • Ran through manual testing with S3 locally, working as expected.

Note about CI

  • Ignore Ci - preexisting failure due to codechecker / phpdoc problems

@matthewhilton matthewhilton marked this pull request as draft October 3, 2024 01:30
@matthewhilton
Copy link
Contributor Author

Closing as won't merge as this branch is too far out of date, but will leave branch as reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant