Skip to content

Commit

Permalink
Fast follow of #1429: fix typo in version specifier (#1431)
Browse files Browse the repository at this point in the history
Fixes a misplaced single quote.

## Before:

![image](https://github.com/user-attachments/assets/0b73bf65-4802-49bb-a64f-0d46aa2dd250)
We set `VERSION_SPECIFIER='=='${{ env.VERSION }}`, and this evaluates to
`'=='0.98.0rc2`.

Instead, we need it to evaluate to `'==0.98.0rc2'`.

## After:
I can't test this in github actions unless this is merged and deployed,
but I tried to test locally:

![image](https://github.com/user-attachments/assets/8831765c-3073-4823-b89c-2d779b7f62f0)

This PR moves the `'` character to what I think is the correct place for
the version specifier string to be interpreted correctly by pip.
  • Loading branch information
achantavy authored Jan 2, 2025
1 parent 337dd6b commit 9c31e9e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/publish-to-ghcr-and-pypi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,4 +86,4 @@ jobs:
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
# e.g. '==0.98.0'
build-args: VERSION_SPECIFIER='=='${{ env.VERSION }}
build-args: VERSION_SPECIFIER='==${{ env.VERSION }}'

0 comments on commit 9c31e9e

Please sign in to comment.