Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a note on python hanging issue on Windows #263

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Conversation

anenadic
Copy link
Collaborator

@anenadic anenadic commented Nov 9, 2023

Fixes #175.

Copy link
Collaborator

@steve-crouch steve-crouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to consider working the 'Making sure...' callout into the main text itself, since a callout is sometimes seen as optional - if they choose not to do it, and later encounter the Python invocation problem, they may miss the handy link to the resolution in the callout.

@anenadic
Copy link
Collaborator Author

anenadic commented Nov 20, 2023

Might want to consider working the 'Making sure...' callout into the main text itself, since a callout is sometimes seen as optional - if they choose not to do it, and later encounter the Python invocation problem, they may miss the handy link to the resolution in the callout.

I wanted to make it visually distinctive so it is not missed in the large body of text - how about I use the .prereq block instead?

Fixed via 8dedd54.

@anenadic anenadic requested review from steve-crouch and removed request for bielsnohr November 20, 2023 10:40
Copy link
Collaborator

@steve-crouch steve-crouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that's a good way to highlight it.

@anenadic anenadic merged commit 4f6f95a into gh-pages Nov 20, 2023
2 checks passed
@anenadic anenadic deleted the issue-175 branch November 20, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows python3 issue
2 participants