Split {format} and allow use of {binary-ext} in pkg-url #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This from feedback in #19:
This is only a readme fix afaict, I changed all occurences of
bin-path
in there tobin-dir
.This introduces two new substitutions:
binary-ext
is the old "format
inbin-dir
"archive-format
is the old "format
inpkg-url
"Contents are unchanged:
binary-ext
includes the dot,archive-format
doesn't. That makes it easy to upgrade and also personally I slightly prefer it that way.The old contextual
format
is still available, "soft deprecated": it will be accepted silently so everything will work, but all documentation will use the new syntax. In the future we could move to a "hard deprecated" model where installing a package that usesformat
will warn the user / tell them to report that to the maintainer. I don't think we'll ever really be able to remove it but that should be good enough.A cool new feature is that
binary-ext
is now usable inpkg-url
, which will be useful for raw binary downloads:I've also added a bunch of tests to GhCrateMeta around the templating for
pkg-url
.