Feature: SupportdDisable of strategies for crate using Cargo.toml
#1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
passcod
reviewed
Jul 23, 2024
|
Are we allowing cli options to override the opinion of the maintainer? |
passcod
approved these changes
Jul 23, 2024
Nope, Seems like a mistake, I'd change that |
Signed-off-by: Jiahao XU <[email protected]>
|
Thanks, I've updated and fixed the issue |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Signed-off-by: Jiahao XU <[email protected]>
NobodyXu
added a commit
that referenced
this pull request
Jul 24, 2024
For #1828 and #1721 Signed-off-by: Jiahao XU <[email protected]>
NobodyXu
added a commit
that referenced
this pull request
Jul 26, 2024
For #1828 and #1721 Signed-off-by: Jiahao XU <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 26, 2024
* Update doc in SUPPORT.md for disabled-strategies For #1828 and #1721 Signed-off-by: Jiahao XU <[email protected]> * Update SUPPORT.md Signed-off-by: Jiahao XU <[email protected]> --------- Signed-off-by: Jiahao XU <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #1721
This allow the maintainer of the crate to disable certain strategies of cargo-binstall, to ensure that the source of the binary is from the one that maintainer provided.