Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(copybutton): react and wc parity #18318

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

anamikaanu96
Copy link
Contributor

Closes #17928

Copy button - react and wc parity

Changelog

Changed

  • packages/web-components/src/components/copy-button/copy-button.stories.ts
  • packages/web-components/src/components/copy-button/copy-button.ts
  • packages/web-components/src/components/copy/copy.ts

Testing / Reviewing

Found that three props (align, autoAlign, and as) were missing and added the align and autoAlign props.
As per the discussion I haven't included as prop.

Tested using storybook , can be checked in storybook controls.

@anamikaanu96 anamikaanu96 requested a review from a team as a code owner January 9, 2025 10:40
Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 472a78a
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/677fb5776c874d0008b8af89
😎 Deploy Preview https://deploy-preview-18318--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 472a78a
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/677fb5773a11b00008efa32f
😎 Deploy Preview https://deploy-preview-18318--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 472a78a
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/677fb577906eee0008bba44d
😎 Deploy Preview https://deploy-preview-18318--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.17%. Comparing base (9217609) to head (472a78a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18318   +/-   ##
=======================================
  Coverage   84.17%   84.17%           
=======================================
  Files         408      408           
  Lines       14435    14435           
  Branches     4690     4640   -50     
=======================================
  Hits        12150    12150           
- Misses       2120     2121    +1     
+ Partials      165      164    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React|WC Parity: Copy-button
1 participant